Review requested:

• @nodejs/gyp

Fast-track has been requested by @anonrig. Please 👍 to approve.

CI: https://ci.nodejs.org/job/node-test-pull-request/57825/

It seems the existing tests are failing. cc @RafaelGSS @nodejs/platform-windows

It looks like cctest/test_path.cc doesn't pass on Windows

C:\workspace\node-compile-windows\node\test\cctest\test_path.cc:21
Expected equality of these values:
  PathResolve(*env, {"c:/ignore", "d:\\a/b\\c/d", "\\e.exe"})
    Which is: "\\e.exe"
  "d:\\e.exe"

The reason behind this is the PathResolve implementation on Windows. All of the failing cases have one thing in common - the last path in the list starts with a path separator (either \\ or /) thus it is evaluated as an absolute path, which it is not.

I see that those test cases are taken from test-path-resolve.js and that the implementation is taken from path.js. However, I found this difference when comparing the two path resolve implementations: JS code, C++ code. Changing this solved the test failures for me locally.

diff --git a/src/path.cc b/src/path.cc
index 6a56b750d6e..78dd5804fc3 100644
--- a/src/path.cc
+++ b/src/path.cc
@@ -101,7 +101,7 @@ std::string PathResolve(Environment* env,
   const size_t numArgs = paths.size();
   auto cwd = env->GetCwd(env->exec_path());
 
-  for (int i = numArgs - 1; i >= -1 && !resolvedAbsolute; i--) {
+  for (int i = numArgs - 1; i >= -1; i--) {
     std::string path;
     if (i >= 0) {
       path = std::string(paths[I]);

Thank you @StefanStojanovic. Updated the pull-request.

CI: https://ci.nodejs.org/job/node-test-pull-request/57838/

CI: https://ci.nodejs.org/job/node-test-pull-request/57842/

CI: https://ci.nodejs.org/job/node-test-pull-request/57844/

CI: https://ci.nodejs.org/job/node-test-pull-request/57846/

CI: https://ci.nodejs.org/job/node-test-pull-request/57859/

Landed in 0b67673