test: fix typos by NathanBaulch · Pull Request #55063 · nodejs/node

NathanBaulch · 2024-09-22T11:01:35Z

Just thought I'd contribute some typo fixes that I stumbled on. Nothing controversial (hopefully).

Use the following command to get a quick summary of the specific corrections made:

git diff HEAD^! --word-diff-regex='\w+' -U0 \
  | grep -E '\[\-.*\-\]\{\+.*\+\}' \
  | sed -r 's/.*\[\-(.*)\-\]\{\+(.*)\+\}.*/\1 \2/' \
  | sort | uniq -c | sort -n

FWIW, the top typos are:

exptected
conent
compatability
verifiy
determing
occurence
declaraion
inut
destroyd
splitted
treshold
thowing
descripton
seperator
preceeding
triggerred

nodejs-github-bot · 2024-09-22T11:01:40Z

Review requested:

@nodejs/single-executable
@nodejs/web-standards

panva · 2024-09-22T11:12:40Z

@NathanBaulch thank you for your first contribution!

I only skimmed through the changed files to see if anything stands out, don't take this as a review of your changes as a whole, just this bit:

Please revert all changes made in the test/fixtures/wpt directory (and its sub-directories), those are coming from an upstream project.

panva · 2024-09-22T11:14:55Z

I would also recommend to split the remaining typo fixes into 3 separate PRs

typo fixes to file content's comments
typo fixes to file content's non-comments
typo fixes in file names

NathanBaulch · 2024-09-24T01:58:00Z

Sure, we can start with the comment typos in this PR @panva - I've restored all the non-comment ones.

nodejs-github-bot · 2024-09-24T07:56:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62717/

codecov · 2024-09-24T09:20:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.25%. Comparing base (ffe0dc5) to head (45ca0fd).
Report is 401 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #55063   +/-   ##
=======================================
  Coverage   88.24%   88.25%           
=======================================
  Files         651      651           
  Lines      183877   183877           
  Branches    35853    35858    +5     
=======================================
+ Hits       162269   162281   +12     
+ Misses      14899    14892    -7     
+ Partials     6709     6704    -5

see 25 files with indirect coverage changes

nodejs-github-bot · 2024-09-24T11:09:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62726/

avivkeller · 2024-09-22T17:09:45Z

test/common/index.js

 // If env var is set then enable async_hook hooks for all tests.
 if (process.env.NODE_TEST_WITH_ASYNC_HOOKS) {
-  const destroydIdsList = {};
+  const destroyIdsList = {};


Should this be "destroy" or "destroyed"?

I wasn't sure, happy to change it.

nodejs-github-bot · 2024-09-27T15:26:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62803/

mcollina

lgtm

nodejs-github-bot · 2024-09-28T09:46:19Z

Commit Queue failed

- Loading data for nodejs/node/pull/55063
✔  Done loading data for nodejs/node/pull/55063
----------------------------------- PR info ------------------------------------
Title      test: fix typos (#55063)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     NathanBaulch:typos-test -> nodejs:main
Labels     test, addons, esm, author ready, needs-ci
Commits    2
 - test: fix typos
 - test: restore non-comment typos
Committers 1
 - Nathan Baulch <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/55063
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/55063
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 22 Sep 2024 11:01:35 GMT
   ✔  Approvals: 2
   ✔  - Filip Skokan (@panva): https://github.com/nodejs/node/pull/55063#pullrequestreview-2324365793
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/55063#pullrequestreview-2334977790
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-09-27T15:26:50Z: https://ci.nodejs.org/job/node-test-pull-request/62803/
- Querying data for job/node-test-pull-request/62803/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
   18acff0d01..f5d454ac7e  main       -> origin/main
✔  origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
 - 5aadbb8ad2 src: add receiver to fast api callback methods
 - f5d454ac7e src: add receiver to fast api callback methods
--------------------------------------------------------------------------------
HEAD is now at f5d454ac7e src: add receiver to fast api callback methods
   ✔  Reset to origin/main
- Downloading patch for 55063
From https://github.com/nodejs/node
 * branch                  refs/pull/55063/merge -> FETCH_HEAD
✔  Fetched commits as f5d454ac7e6b..45ca0fd106d8
--------------------------------------------------------------------------------
Auto-merging test/es-module/test-typescript.mjs
[main 1348c25f7f] test: fix typos
 Author: Nathan Baulch <[email protected]>
 Date: Sun Sep 22 15:03:43 2024 +1000
 72 files changed, 275 insertions(+), 275 deletions(-)
 rename test/benchmark/{test-bechmark-readline.js => test-benchmark-readline.js} (100%)
Auto-merging test/es-module/test-typescript.mjs
[main f1e42cb278] test: restore non-comment typos
 Author: Nathan Baulch <[email protected]>
 Date: Tue Sep 24 11:56:41 2024 +1000
 33 files changed, 231 insertions(+), 231 deletions(-)
 rename test/benchmark/{test-benchmark-readline.js => test-bechmark-readline.js} (100%)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

test: fix typos
PR-URL: #55063

Reviewed-By: Filip Skokan <[email protected]>

Reviewed-By: Matteo Collina <[email protected]>
[detached HEAD a892fa29fd] test: fix typos

Author: Nathan Baulch <[email protected]>

Date: Sun Sep 22 15:03:43 2024 +1000

72 files changed, 275 insertions(+), 275 deletions(-)

rename test/benchmark/{test-bechmark-readline.js => test-benchmark-readline.js} (100%)

Rebasing (3/4)

Rebasing (4/4)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

test: restore non-comment typos
PR-URL: #55063

Reviewed-By: Filip Skokan <[email protected]>

Reviewed-By: Matteo Collina <[email protected]>
[detached HEAD a5bfc4cefb] test: restore non-comment typos

Author: Nathan Baulch <[email protected]>

Date: Tue Sep 24 11:56:41 2024 +1000

33 files changed, 231 insertions(+), 231 deletions(-)

rename test/benchmark/{test-benchmark-readline.js => test-bechmark-readline.js} (100%)
Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/11082939946

nodejs-github-bot · 2024-09-28T13:58:57Z

Landed in 28c7394

PR-URL: #55063 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

PR-URL: nodejs#55063 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

nodejs-github-bot added addons Issues and PRs related to native addons. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 22, 2024

NathanBaulch added 2 commits September 24, 2024 11:57

test: fix typos

a15534a

test: restore non-comment typos

45ca0fd

NathanBaulch force-pushed the typos-test branch from bd182e6 to 45ca0fd Compare September 24, 2024 01:57

panva approved these changes Sep 24, 2024

View reviewed changes

panva added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 24, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 24, 2024

avivkeller reviewed Sep 24, 2024

View reviewed changes

avivkeller added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 27, 2024

mcollina approved these changes Sep 28, 2024

View reviewed changes

mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 28, 2024

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 28, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 28, 2024

nodejs-github-bot merged commit 28c7394 into nodejs:main Sep 28, 2024

NathanBaulch deleted the typos-test branch September 29, 2024 06:59

targos pushed a commit that referenced this pull request Oct 4, 2024

test: fix typos

f538ba1

PR-URL: #55063 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

targos pushed a commit that referenced this pull request Oct 4, 2024

test: fix typos

9aeba48

PR-URL: #55063 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

NathanBaulch mentioned this pull request Oct 9, 2024

test: fix typos #55341

Open

aduh95 mentioned this pull request Oct 9, 2024

V22.10.0 proposal #55343

Merged

louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024

test: fix typos

895c8fa

PR-URL: nodejs#55063 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Nov 16, 2024

tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024

test: fix typos

7aa63ad

PR-URL: nodejs#55063 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

Uh oh!

Conversation

NathanBaulch commented Sep 22, 2024

Uh oh!

nodejs-github-bot commented Sep 22, 2024

Uh oh!

panva commented Sep 22, 2024

Uh oh!

panva commented Sep 22, 2024

Uh oh!

NathanBaulch commented Sep 24, 2024

Uh oh!

nodejs-github-bot commented Sep 24, 2024

Uh oh!

codecov bot commented Sep 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Sep 24, 2024

Uh oh!

avivkeller Sep 22, 2024

Choose a reason for hiding this comment

Uh oh!

NathanBaulch Sep 24, 2024

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Sep 27, 2024

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Sep 28, 2024

PR-URL: #55063 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

PR-URL: #55063 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

Successfully rebased and updated refs/heads/main.

Uh oh!

nodejs-github-bot commented Sep 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov bot commented Sep 24, 2024 •

edited

Loading

PR-URL: #55063
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>

PR-URL: #55063
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>