Skip to content

src: -Wmismatched-new-delete in debug_utils.cc#58844

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
codebytere:fix-Wmismatched-new-delete
Jun 28, 2025
Merged

src: -Wmismatched-new-delete in debug_utils.cc#58844
nodejs-github-bot merged 1 commit intonodejs:mainfrom
codebytere:fix-Wmismatched-new-delete

Conversation

@codebytere
Copy link
Member

@codebytere codebytere commented Jun 26, 2025

Refs #57738

Fixes the following:

Error: ../../third_party/electron_node/src/debug_utils.cc(491,11): error: 'delete' applied to a pointer that was allocated with 'new[]'; did you mean 'delete[]'? [-Werror,-Wmismatched-new-delete]
  491 |           delete str;
      |           ^
      |                 []
../../third_party/electron_node/src/debug_utils.cc(487,23): note: allocated with 'new[]' here
  487 |           char* str = new char[size];
      |                       ^
1 error generated.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. labels Jun 26, 2025
@codecov
Copy link

codecov bot commented Jun 26, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.08%. Comparing base (b4c5fb4) to head (e2d27be).
⚠️ Report is 782 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #58844   +/-   ##
=======================================
  Coverage   90.08%   90.08%           
=======================================
  Files         640      640           
  Lines      188446   188446           
  Branches    36960    36960           
=======================================
+ Hits       169757   169769   +12     
+ Misses      11412    11398   -14     
- Partials     7277     7279    +2
Files with missing lines Coverage Δ
src/debug_utils.cc 60.90% <ø> (ø)

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codebytere codebytere force-pushed the fix-Wmismatched-new-delete branch from 5599b2b to e2d27be Compare June 26, 2025 13:37
@codebytere codebytere changed the title fix: -Wmismatched-new-delete in debug_utils.cc src: -Wmismatched-new-delete in debug_utils.cc Jun 26, 2025
@Ethan-Arrowood Ethan-Arrowood added request-ci Add this label to start a Jenkins CI on a PR. labels Jun 26, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 26, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 26, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67668/

@codebytere codebytere removed the needs-ci PRs that need a full CI run. label Jun 27, 2025
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 27, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 28, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 28, 2025

Commit Queue failed
node:internal/process/promises:394
    triggerUncaughtException(err, true /* fromPromise */);
    ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/opt/hostedtoolcache/node/22.16.0/x64/lib/node_modules/@node-core/utils/node_modules/css-select/lib/esm/index.js' imported from /opt/hostedtoolcache/node/22.16.0/x64/lib/node_modules/@node-core/utils/node_modules/cheerio-select/lib/esm/index.js

Did you mean to import "css-select/lib/index.js"?

at finalizeResolution (node:internal/modules/esm/resolve:275:11)

at moduleResolve (node:internal/modules/esm/resolve:860:10)

at defaultResolve (node:internal/modules/esm/resolve:984:11)

at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:780:12)

at #cachedDefaultResolve (node:internal/modules/esm/loader:704:25)

at ModuleLoader.resolve (node:internal/modules/esm/loader:687:38)

at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:305:38)

at ModuleJob._link (node:internal/modules/esm/module_job:137:49) {

code: 'ERR_MODULE_NOT_FOUND',

url: 'file:///opt/hostedtoolcache/node/22.16.0/x64/lib/node_modules/@node-core/utils/node_modules/css-select/lib/esm/index.js'

}


Node.js v22.16.0
https://github.com/nodejs/node/actions/runs/15944333394

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jun 28, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 28, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 28, 2025

Commit Queue failed
node:internal/process/promises:394
    triggerUncaughtException(err, true /* fromPromise */);
    ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/opt/hostedtoolcache/node/22.16.0/x64/lib/node_modules/@node-core/utils/node_modules/css-select/lib/esm/index.js' imported from /opt/hostedtoolcache/node/22.16.0/x64/lib/node_modules/@node-core/utils/node_modules/cheerio-select/lib/esm/index.js

Did you mean to import "css-select/lib/index.js"?

at finalizeResolution (node:internal/modules/esm/resolve:275:11)

at moduleResolve (node:internal/modules/esm/resolve:860:10)

at defaultResolve (node:internal/modules/esm/resolve:984:11)

at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:780:12)

at #cachedDefaultResolve (node:internal/modules/esm/loader:704:25)

at ModuleLoader.resolve (node:internal/modules/esm/loader:687:38)

at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:305:38)

at ModuleJob._link (node:internal/modules/esm/module_job:137:49) {

code: 'ERR_MODULE_NOT_FOUND',

url: 'file:///opt/hostedtoolcache/node/22.16.0/x64/lib/node_modules/@node-core/utils/node_modules/css-select/lib/esm/index.js'

}


Node.js v22.16.0
https://github.com/nodejs/node/actions/runs/15945110344

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jun 28, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 28, 2025
@nodejs-github-bot nodejs-github-bot merged commit 1c2fa7e into nodejs:main Jun 28, 2025
84 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 28, 2025

Landed in 1c2fa7e

targos pushed a commit that referenced this pull request Jul 3, 2025
@codebytere @targos
src: -Wmismatched-new-delete in debug_utils.cc
2445f86 
PR-URL: #58844
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@github-actions github-actions bot mentioned this pull request Jul 8, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@codebytere @aduh95
src: -Wmismatched-new-delete in debug_utils.cc
5f704f6 
PR-URL: #58844
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
@codebytere @aduh95
src: -Wmismatched-new-delete in debug_utils.cc
6b30c0a 
PR-URL: #58844
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@github-actions github-actions bot mentioned this pull request Jul 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. debugger Issues and PRs related to the debugger subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@codebytere @nodejs-github-bot @addaleax @lpinca @tniessen @Ethan-Arrowood @aduh95