tools: enable linting for chained properties#7999
tools: enable linting for chained properties#7999Trott wants to merge 2 commits intonodejs:masterfrom
Conversation
|
( |
|
/cc @silverwind |
|
Raspberry Pi build-type failures in Ci. Certainly unrelated. But let's re-run anyway: https://ci.nodejs.org/job/node-test-pull-request/3560/ |
|
Rubber stamp LGTM on the ESLint update. Actual LGTM on the other commit. |
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
|
More flaky failures in that last CI run but still unrelated. CI has been particularly flaky here this past week :-( /cc @nodejs/build Will go ahead and land this but definitely need to keep an eye on things. |
|
actually... hmmm.. @Trott, after applying this patch locally I'm getting: When I pull this patch back out it works. |
|
Oh, interesting. The Makefile looks for the |
|
OK, fixed |
PR-URL: nodejs#7999 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
Refs: nodejs#7920 PR-URL: nodejs#7999 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
PR-URL: #7999 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
Refs: #7920 PR-URL: #7999 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
6 participants
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
tools
Description of change
Enforces linting for indentation of multiline chained properties. Requires updating to ESLint 3.2.2.
Refs: #7920