Update tap13 from upstream, reapply py3 compatibility PR#18
Closed
sam-github wants to merge 3 commits intomasterfrom
Closed
Update tap13 from upstream, reapply py3 compatibility PR#18sam-github wants to merge 3 commits intomasterfrom
sam-github wants to merge 3 commits intomasterfrom
Conversation
Author
|
@rajcze @jbergstroem PTAL I had to reapply py3 compat, and the builtin tests are failing: Its odd that exit code is |
Pulled lastest from upstream:
$ curl -o tap2junit/tap13.py \
https://bitbucket.org/fedoraqa/pytap13/raw/master/pytap13.py
Note that the upstream version is now under the Apache License.
Fixes nodejs/admin#413
Floating patch for Python 3 support. PR-URL: #5 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matt (IPv4) Cowley <[email protected]>
a9e3828 to
cd0342e
Compare
Author
|
@jbergstroem any thoughts? the new version has a license that doesn't cause any IP issues, do you think its functional? |
Member
Happy to merge it. I haven't had the time to look at the failing tests though.. |
Author
|
@cclauss do you have any interest in figuring out how to make the updated tap13 work/pass tests? |
This was referenced Oct 23, 2019
Author
|
Replaced by #19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and
Fixes nodejs/admin#413