Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2560 +/- ##
==========================================
- Coverage 85.54% 85.29% -0.26%
==========================================
Files 76 84 +8
Lines 6858 7624 +766
==========================================
+ Hits 5867 6503 +636
- Misses 991 1121 +130 ☔ View full report in Codecov by Sentry. |
ronag
left a comment
There was a problem hiding this comment.
The benchmark results seem to indicate this PR is slower?
|
@ronag |
ronag
left a comment
There was a problem hiding this comment.
The for each results look suspicious. Either there is something wrong with the benchmark or then implementation.
9c0c22b to
0b0823a
Compare
There was a problem hiding this comment.
I would argue that the performance improvements are too small relative to the maintenance cost.
@KhafraDev wdyt?
|
Yeah agreed. The forEach benchmarks are misleading because the implementation is now wrong (probably, I'd have to test it out). The WPTs must not cover inserting entries while iterating over it. |
0b0823a to
f07b204
Compare
f07b204 to
5088696
Compare
Benchmark
Benchmark Script