refactor: try to reduce amount of http2 specific logic#2816
refactor: try to reduce amount of http2 specific logic#2816
Conversation
|
@metcoder95 can you help me figure out why this change breaks tests? |
|
Sure thing, I'll take a look; sorry for being quite slow has been busy lately 🙇 |
|
@metcoder95 some more changes, I think you get the gist |
ronag
force-pushed
the
http2-http
branch
2 times, most recently
from
c0d2eae to
45803d6
Compare
metcoder95
left a comment
metcoder95
left a comment
There was a problem hiding this comment.
So far, the idea LGTM; I would like to see if we can scope the H2 logic even more, but we can do it in another PR, I'll check the test first 👍
| util.destroy(this, err) | ||
| util.destroy(socket, err) |
There was a problem hiding this comment.
| util.destroy(this, err) | |
| util.destroy(socket, err) | |
| this.destroy(err) | |
| socket.destroy(err) |
Steps towards more clean separation between h1 and h2. Refs: #2816
|
do you want me to wait for #2839 to land? |
Sorry for that one. Just got an idea and went with it. Hopefully didn't cause you unnecessary work. |
2 participants
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status