chore(workflows/nightly.yml): create issue only on all platforms fail#3020
Merged
mcollina merged 1 commit intonodejs:mainfrom Mar 30, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3020 +/- ##
=======================================
Coverage 93.51% 93.51%
=======================================
Files 89 89
Lines 24231 24231
=======================================
Hits 22659 22659
Misses 1572 1572 ☔ View full report in Codecov by Sentry. |
ronag
pushed a commit
that referenced
this pull request
Apr 2, 2024
mcollina
pushed a commit
that referenced
this pull request
Apr 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Rationale
In the four nightly failures so far, 3 were not undici's fault and only one platform failed. In the one true positive error, all three platforms failed tests, therefore only create/comment issue if all three platform fail.
Sample Runs
No issue created
No issue created
Issue created: Nightly tests are failing mweberxyz/nodejs-undici#8
Changes
.github/workflows/nightly.yml:
report-failureif all three platforms failFeatures
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status