Closed
Conversation
Co-authored-by: Carlos Fuentes <[email protected]>
Co-authored-by: Carlos Fuentes <[email protected]>
Co-authored-by: Carlos Fuentes <[email protected]>
Contributor
Author
|
I need help with fixing test on mac os (works on windows and linux) Test: on mac os this test fails with: on windows and linux this test resolves correctly |
ronag
reviewed
Jun 20, 2024
ronag
requested changes
Jun 20, 2024
Member
ronag
left a comment
There was a problem hiding this comment.
I don't think this is necessary. Already possible:
import CacheableLookup from 'cacheable-lookup';
const cacheable = new CacheableLookup(opts)
const agent = new Agent({
connect: { lookup: cacheable.lookup }
})
Contributor
Author
|
Mentioning reviewers from orginal pr @mcollina @ShogunPanda @metcoder95 @KhafraDev , should I continue or close this pr ? |
Member
|
As ronag mentioned it's already possible to use cacheable-lookup |
Member
|
The only reason I could see for adding it is if we wanted to enable it by default, but we're probably better off just documenting it |
Contributor
Author
Member
|
Examples |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
#2552
Rationale
This is version of dns cache with resolved merge conflicts and tests migrated to
node:test, most of the work is done by @antoinegomezChanges
Features
Bug Fixes
Breaking Changes and Deprecations
Status