Implement new .NET Core 3.0 ADO.NET APIs#2498
Merged
roji merged 1 commit intonpgsql:devfrom Jul 7, 2019
Merged
Conversation
Pin dotnet sdk to 3.0.0-preview6 and implement new ADO.NET APIs introduced in .NET Core 3.0: * https://github.com/dotnet/corefx/issues/35564 * https://github.com/dotnet/corefx/issues/35012 Note: we cross-target netcoreapp3.0 since the new APIs aren't yet available in netstandard2.1, but this is expected to happen soon. Fixes npgsql#2481
Contributor
Maybe we should wait for this? |
Member
Author
|
@YohDeadfall I'm working on it on the Microsoft side, but the idea was to get it in (afterwards it's just changing some #ifdefs). If this really bothers you we can wait. |
YohDeadfall
approved these changes
Jun 26, 2019
Contributor
YohDeadfall
left a comment
YohDeadfall
left a comment
There was a problem hiding this comment.
No, I'm fine with it if it doesn't appear soon in the standard. Otherwise, I prefer to wait a bit.
Member
Author
|
Actually the three new APIs have made it into the standard in time for preview7 (dotnet/standard#1290, dotnet/standard#1284, dotnet/standard#1283), so am going to hold off on merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin dotnet sdk to 3.0.0-preview6 and implement new ADO.NET APIs introduced in .NET Core 3.0:
Note: we cross-target netcoreapp3.0 since the new APIs aren't yet
available in netstandard2.1, but this is expected to happen soon.
Fixes #2481