unsupported: npm v6.10.0 breaks on node v6.0, v6.1, v9.0 - v9.2#279
Closed
ljharb wants to merge 1 commit intonpm:latestfrom
Closed
unsupported: npm v6.10.0 breaks on node v6.0, v6.1, v9.0 - v9.2#279ljharb wants to merge 1 commit intonpm:latestfrom
ljharb wants to merge 1 commit intonpm:latestfrom
Conversation
Contributor
Author
|
The failing test is in "test/tap/all-package-metadata.js" on node 12 in a rimraf call; i wonder if it's flaky and needs to be rerun? |
Merged
3 tasks
ruyadorno
approved these changes
Nov 5, 2019
This was referenced Nov 14, 2019
This was referenced Nov 25, 2019
This was referenced Dec 5, 2019
This was referenced Dec 18, 2019
This was referenced Jan 17, 2020
This was referenced Feb 25, 2020
This was referenced Mar 14, 2020
This was referenced Mar 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nvm-sh/nvm@100861d
npm v6.10 caused npm to no longer work on node v6.0, v6.1, v9.0, v9.1, and v9.2.
This PR isn't to debate semver adherence, though, I just want to update the "unsupported" logic to be correct :-)
I'd also like to update the
supportedNodelist, but it'd need a "max" to be supported, or instead of "min" a semver range, and that seemed like a bigger change.