Skip to content

deps: [email protected] and dedupe vulnerable deps#4459

Merged
lukekarrys merged 1 commit intorelease-nextfrom
lk/audit-deps
Feb 23, 2022
Merged

deps: [email protected] and dedupe vulnerable deps#4459
lukekarrys merged 1 commit intorelease-nextfrom
lk/audit-deps

Conversation

@lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Feb 22, 2022

Closes #3785
Closes #4373

@lukekarrys lukekarrys requested a review from a team as a code owner February 22, 2022 23:46
@lukekarrys
Copy link
Contributor Author

lukekarrys commented Feb 22, 2022

I also took a look at why we use 3 dependencies for cli table/column formatting (cli-table3, columnify, cli-columns). They each do something slightly differently for us, and while it may be worthwhile trying to find a single dep to do all three, that is outside the scope of this PR.

@npm-robot
Copy link
Contributor

npm-robot commented Feb 23, 2022 •
edited
Loading

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 52.206 ±1.07 32.649 ±0.16 37.270 ±24.92 21.986 ±0.77 3.231 ±0.10 3.281 ±0.05 2.645 ±0.14 12.477 ±0.09 2.562 ±0.04 3.745 ±0.02
#4459 0.467 ±0.00 0.458 ±0.00 0.447 ±0.01 0.456 ±0.00 0.457 ±0.01 0.450 ±0.00 0.445 ±0.00 0.476 ±0.03 0.454 ±0.00 0.464 ±0.02
app-medium clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 38.541 ±1.07 25.538 ±0.08 14.450 ±0.12 15.405 ±0.26 2.864 ±0.00 2.958 ±0.05 2.609 ±0.04 9.524 ±0.01 2.405 ±0.00 3.383 ±0.03
#4459 0.472 ±0.01 0.498 ±0.04 0.479 ±0.01 0.472 ±0.01 0.453 ±0.01 0.452 ±0.00 0.459 ±0.01 0.460 ±0.01 0.464 ±0.02 0.465 ±0.02

@lukekarrys lukekarrys merged commit 5b29666 into release-next Feb 23, 2022
@lukekarrys lukekarrys deleted the lk/audit-deps branch February 23, 2022 15:28
@lukekarrys lukekarrys mentioned this pull request Feb 24, 2022
Merged
@npm-robot npm-robot mentioned this pull request Feb 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lukekarrys @npm-robot @wraithgar