Merged
Conversation
Member
Author
|
Going to also add a commit removing the "bug the author" message on a 404. |
Contributor
|
That seems like a registry change that would break older and current clients; can the registry send that value even if modern npm isn’t using it? |
wraithgar
changed the title
Contributor
|
Seeing a related PR, how is it a privacy concern to tell me my own name? |
Member
Author
|
The registry doesn't send that anymore, so this cleans the message up. Having the npm registry send dummy data there for old clients would be something you can request via https://www.npmjs.com/support |
Contributor
|
Right, but why did the registry stop sending that info? and when was that breaking change announced? |
It is no longer returned from the npm registry
wraithgar
force-pushed
the
gar/unpublished-undefined
branch
from
478cc81 to
62e21c8
Compare
Contributor
|
no statistically significant performance changes detected timing results
|
nlf
approved these changes
Mar 16, 2022
Merged
Open
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits here, one removes the user name from the unpublished message, as that's no longer returned by the npm registry. The second one removes the "bug the author" message from the package 404, that copy is outdated and from a different era.