deps: [email protected] and all related deps#5933
Merged
lukekarrys merged 7 commits intolatestfrom Dec 7, 2022
Merged
Conversation
Contributor
lukekarrys
commented
Dec 7, 2022
- deps: [email protected]
- deps: [email protected]
- deps: [email protected]
- deps: [email protected]
- deps: [email protected]
- deps: [email protected]
- deps: [email protected]
Member
|
That's a lot of duping of 3 down into the tree. Are there other packages we control that need to get on minipass@4 first? |
Contributor
|
some of them are ours, but not all i don't think.. here's a list of everything still on minipass@3 for our future selves:
|
Contributor
Author
|
Is this worth merging in the meantime even though we are at |
Contributor
Author
|
Got some data on tarball size from packing before and after this PR showing the total increase in tarball size is latest ❯ node . pack
npm notice === Tarball Details ===
npm notice name: npm
npm notice version: 9.1.3
npm notice filename: npm-9.1.3.tgz
npm notice package size: 2.4 MB
npm notice unpacked size: 9.7 MB
npm notice shasum: b4e60b63041e1c582c44ad570ab94c3cd50bb343
npm notice integrity: sha512-/lKNkqYzebc6D[...]ZCIrmu53DapjA==
npm notice bundled deps: 194
npm notice bundled files: 0
npm notice own files: 2031
npm notice total files: 2031
npm notice
npm-9.1.3.tgz
❯ stat --printf="%s" npm-9.1.3.tgz
2421762this PR |
nlf
approved these changes
Dec 7, 2022
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.