Conversation
|
That failure is strange. It is in a test added for the OpenBLAS threading model on windows numpy/numpy#27036 and is now showing up on cp3.14 on windows. I don't see other failures of that test here, and don't remember failures in the numpy/numpy repo. The relevant change between the successful builds with scipy-openblas-0.3.30.0.2 and the failing build here with scipy-openblas-0.3.3.30.0.6 is patching OpenBLAS with threaded calls in numpy/numpy#29391, but that patch should only involve pthreads. |
|
Hmm. The only windows runs we have in regular CI are
|
|
Preserving the error here and rerunning the failed CI run Preserve the error |
|
Rerunning the CI job passed, indicating the test is flaky. |
rgommers
left a comment
There was a problem hiding this comment.
As I think I've said before (#6 (comment)), I didn't do this on purpose - it feels like (a) it's the wrong way around, and (b) this installs more dependencies than we need to (spin, click) in almost all CI jobs. And a generically-named file like ci_requirements.txt is not unlikely to get even more packages added to it over time.
If we want to auto-sync these, the better approach is probably to:
- take a single job in the main repo and make that clone this repo
- check (on PRs to the
mainbranch only)openblas_requirements.txtvs.ci_requirements.txtversion numbers are equal or the ones inopenblas_requirements.txtare higher, and fail if that's not the case.- then, to bump the version, this repo has to be updated first, so it can't go out of date
custom_checksis probably the right job: https://github.com/numpy/numpy/blob/0fdb1979cdfcdd31b61f423b66a384fabd1d7fd7/.github/workflows/linux.yml#L323
There are 7 active Windows jobs, 3 non-wheel and 2 wheel build jobs on GHA and 2 on Azure. The Cygwin one was disabled early this year. |
I'm happy to implement this later today if that helps |
|
Ok, closing |
|
Changing the name of |
Previously, this repo had its own, perhap different, requirements file for OpenBLAS. We should use the one from the NumPy we are building.