fix(nuxt): async-data executes should return new promise on deduplication#33740
Merged
fix(nuxt): async-data executes should return new promise on deduplication#33740
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
fixes #33737
📚 Description
My approach is to always return the new deduped promise for
useAsyncDataexecutes, if the promise is rejected from deduplication. This causes all executions to resolve simultaneously because they are the 'same' promise, and I believe this is the intended behaviour. If I want to perform some actions after execution, I want to do so after the new promise has been resolved, rather than when the old one has been deduplicated.