Show the version for "system" in nvm ls#1287
Conversation
|
wow ... the build failed error message is soooo long lol ... |
|
The reason I never displayed the system version before is because I didn't want anyone to do |
|
@ljharb do you mean to prevent confusion about the version managed by nvm and system? I thought this display is very useful so that I don't need to do |
|
Yes, to prevent that confusion, exactly. What's the use case for checking the system version more than once in a while? |
|
(also, |
|
As I have more than one development environments, which may including FreeBSD, Ubuntu 14.04, Ubuntu 16.04, Debian 7, Debian 8, etc, they all have their own but different nodejs versions, and when I want to use a certain version of nodejs, I will use About the confusion, maybe use |
|
The arrow isn't the thing I'm worried about, it's the version number. Even if a certain version is installed on the system, you generally would want to install it again so that |
|
Not sure if this my personal scenario only, but sometimes I just want to test if a certain version could work with the certain project, I don't really need it to be managed by |
|
I'm fine with adding helpful output next to "system" - but anything that looks like a version number seems like it could dangerously cause confusion. |
|
hmmmm ... then need to think about the how to display since what I want is the version number which is you don't want, haha. |
|
Whatever you come up with, citing examples of other version managers (like rvm, rbenv, virtualenv, etc) and if/how they display the system version would help. |
|
I have not test rvm or the other version managers yet, but come up with |
|
@PeterDaveHello would you mind rebasing this? |
|
Looks like it needs a rewrite, will take some time, a simple rebase doesn't look so good to resolve the conflict. |
|
that's what i was worried about; the changes to use awk in a bunch of places may have complicated this. it'd be great to update the PR with a rewritten approach, though :-) |
c6cfc3a to
c20db2a
Compare
444f885 to
cefd4b0
Compare
|
@ljharb, with some help from GPT-5, the PR has been updated. |
cefd4b0 to
50bed46
Compare
|
This looks great, but it will need some tests :-) |
Normalize `nvm_version` output when `nvm_ls` returns "system vX" so alias and .nvmrc resolutions treat system correctly. Add fast tests for system alias behavior in `nvm ls`, `nvm use`, and `nvm which`.
50bed46 to
568a463
Compare
|
@ljharb, please take a look. |
568a463 to
29a652f
Compare
Show the actual version from "system" for
nvm lsbefore:
after: