Skip to content

Go modernization#785

Merged
reuvenharrison merged 8 commits intomainfrom
go-modernization
Feb 3, 2026
Merged

Go modernization#785
reuvenharrison merged 8 commits intomainfrom
go-modernization

Conversation

@reuvenharrison
Copy link
Collaborator

No description provided.

reuvenharrison and others added 2 commits February 2, 2026 21:54
Mechanical replacement of interface{} with the any type alias
introduced in Go 1.18. No behavioral changes.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Replace manual map key collection loops with
slices.Collect(maps.Keys()) or slices.Sorted(maps.Keys()).

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.40%. Comparing base (0b13917) to head (d171a50).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #785      +/-   ##
==========================================
+ Coverage   89.00%   89.40%   +0.40%     
==========================================
  Files         248      248              
  Lines       12402    12354      -48     
==========================================
+ Hits        11038    11045       +7     
+ Misses        926      862      -64     
- Partials      438      447       +9     
Flag Coverage Δ
unittests 89.40% <100.00%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

reuvenharrison and others added 6 commits February 2, 2026 22:04
…Func

Remove sort.Interface implementations (Len/Less/Swap) from types
where possible and use slices.SortFunc with cmp.Compare instead.
Also migrates sort.Strings calls to slices.Sort.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Replace the experimental slices package with the standard library
version available since Go 1.21.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Use slices.ContainsFunc in findValue (enum_diff.go)
- Fix %v to %w for proper error wrapping (deprecation.go, viper.go)
- Use strings.Contains instead of strings.Index (localizations.go)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
- lint/checker.go: add tests for sorting logic and nil spec handling
- checker/changes.go: add tests for CompareChanges args comparison
- formatters/checks.go: add tests for Checks.SortFunc
- checker/deprecation.go: add test for RFC3339 sunset date parsing
- diff/diff.go: add tests for GetPathsDiff function

Co-Authored-By: Claude Opus 4.5 <[email protected]>
- checker/deprecation.go: cover json.Unmarshal error path
- diff/diff.go: cover getSinceDate function with x-since-date extension

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@reuvenharrison reuvenharrison merged commit a1243f4 into main Feb 3, 2026
14 of 15 checks passed
@reuvenharrison reuvenharrison deleted the go-modernization branch February 3, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants