fix: add media type context to property deprecation messages#786
Merged
reuvenharrison merged 5 commits intomainfrom Feb 3, 2026
Merged
fix: add media type context to property deprecation messages#786reuvenharrison merged 5 commits intomainfrom
reuvenharrison merged 5 commits intomainfrom
Conversation
When multiple media types share the same schema, property deprecation changes were reported multiple times with identical messages. This fix: - Adds media type context to messages when multiple media types exist - Removes the deduplication workaround that hid duplicate reports - Creates helper functions for formatting media type details Messages now show: "property 'x' deprecated (media type: application/json)" instead of appearing as duplicates. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #786 +/- ##
==========================================
+ Coverage 89.40% 89.45% +0.04%
==========================================
Files 248 249 +1
Lines 12354 12409 +55
==========================================
+ Hits 11045 11100 +55
Misses 862 862
Partials 447 447
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Extends the media type context pattern to: - check_request_property_type_changed.go - check_response_property_type_changed.go - check_request_property_enum_value_updated.go - check_response_property_enum_value_removed.go Co-Authored-By: Claude Opus 4.5 <[email protected]>
Extends media type context to all remaining property checks: - Request property checks (default value, enum, type constraints, etc.) - Response property checks (all variants) - Discriminator checks (request and response) Updates test expectations to account for new media type details. Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #594
Test plan
(media type: application/json)when multiple media types exist🤖 Generated with Claude Code