refactor: replace custom string types with Go built-ins#789
Merged
reuvenharrison merged 5 commits intomainfrom Feb 5, 2026
Merged
refactor: replace custom string types with Go built-ins#789reuvenharrison merged 5 commits intomainfrom
reuvenharrison merged 5 commits intomainfrom
Conversation
…types Replace custom utils types with Go built-in equivalents: - StringList -> []string (methods replaced with stdlib: slices.Contains, strings.Join, etc.) - StringMap -> map[string]string - StringPair -> removed (only used internally by deleted CartesianProduct) StringSet is retained as it provides set-algebraic operations (Minus, Plus, Intersection) that Go's stdlib doesn't cover. Updated its ToStringList() to return []string and added StringSetFromSlice() helper. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #789 +/- ##
==========================================
- Coverage 89.49% 89.48% -0.02%
==========================================
Files 249 248 -1
Lines 12456 12425 -31
==========================================
- Hits 11147 11118 -29
+ Misses 862 861 -1
+ Partials 447 446 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
utils.StringListwith[]stringacross the codebase, using stdlib equivalents (slices.Contains,strings.Join,slices.Sort, etc.)utils.StringMap(replaced withmap[string]string) andutils.StringPair(only used internally by deletedCartesianProduct)utils.StringSetas Go has no built-in set type; updateToStringList()to return[]stringand addStringSetFromSlice()helperTest plan
go build ./...passesgo vet ./...passesgo test ./...passes (all 14 packages)utils.StringList,utils.StringMap, orutils.StringPair🤖 Generated with Claude Code