fix: add git to Docker image and improve missing-git error message#801
Merged
reuvenharrison merged 1 commit intomainfrom Mar 9, 2026
Merged
fix: add git to Docker image and improve missing-git error message#801reuvenharrison merged 1 commit intomainfrom
reuvenharrison merged 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #801 +/- ##
=======================================
Coverage 89.57% 89.57%
=======================================
Files 239 239
Lines 12179 12179
=======================================
Hits 10909 10909
Misses 840 840
Partials 430 430
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
git is required for git revision syntax (e.g. origin/main:openapi.yaml). Add it to the Alpine image so Docker and action users get it automatically. Improve the error message when git is not in PATH to make the fix obvious. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
reuvenharrison
force-pushed
the
fix/add-git-to-docker
branch
from
ec0414b to
d15d3dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gitto the Alpine Docker image — required for git revision syntax (origin/main:openapi.yaml) introduced in feat: support git revision syntax for spec paths #799gitis not inPATHfrom a rawexecerror tois git installed and in PATH?Why
The oasdiff-action
pr-commentnow passesorigin/main:openapi.yamldirectly to the oasdiff binary, which callsgit showinternally. The Docker container had nogit, causing:Since the action Dockerfiles are all
FROM tufin/oasdiff:stable, addinggitto the base image fixes the action without any changes to oasdiff-action itself.Test plan
TestLoadInfo_GitRevisionNoGitpasses with the improved error message🤖 Generated with Claude Code