fix: update dependencies and fix kin-openapi v0.134.0 compatibility#803
Merged
reuvenharrison merged 1 commit intomainfrom Mar 14, 2026
Merged
fix: update dependencies and fix kin-openapi v0.134.0 compatibility#803reuvenharrison merged 1 commit intomainfrom
reuvenharrison merged 1 commit intomainfrom
Conversation
Updated go.mod dependencies including kin-openapi to v0.134.0. StringMap became generic (StringMap[V any]) in v0.134.0, and Discriminator.Mapping changed from StringMap to StringMap[MappingRef]. - Remove openapi3 import from string_map_diff.go; use plain map[string]string - Add mappingToStringMap helper in discriminator_diff.go to convert StringMap[MappingRef] → map[string]string via MappingRef.Ref - Update TestViper_InvalidFlag: mapstructure v2.5.0 now includes the struct type name in validation error messages Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #803 +/- ##
==========================================
- Coverage 89.30% 89.29% -0.02%
==========================================
Files 240 240
Lines 12710 12715 +5
==========================================
+ Hits 11351 11354 +3
- Misses 905 906 +1
- Partials 454 455 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kin-openapito v0.134.0StringMapbecame generic (StringMap[V any]) in v0.134.0, andDiscriminator.Mappingchanged type fromStringMaptoStringMap[MappingRef]openapi3import fromstring_map_diff.go; use plainmap[string]stringinsteadmappingToStringMaphelper indiscriminator_diff.goto convertStringMap[MappingRef]→map[string]stringviaMappingRef.RefTestViper_InvalidFlag:mapstructurev2.5.0 now includes the struct type name in validation error messages ('internal.Config'instead of'')Test plan
go build ./...passesgo test ./diff/...passesgo test ./internal/...passes🤖 Generated with Claude Code