Conversation
vaind
force-pushed
the
47-ios
branch
2 times, most recently
from
27e390d to
e182488
Compare
|
|
||
| curl --location --fail --output "${zip}" "${url}" | ||
|
|
||
| rm -rf "${dir}/Carthage" |
There was a problem hiding this comment.
Danger zone? E.g. what if we are not the only ones here?
PS.: But not sure by whom this script is supposed to be run and where (another comment at the top of the script?)
There was a problem hiding this comment.
the info was in the podspec, moved to ios/readme
There was a problem hiding this comment.
no danger of removing anything unintentionally, this is run by a ObjectBox-Dart publisher before a release
|
A high level readme might be nice, explaining the general approach and mentioning the download script and the pod spec. |
| @@ -0,0 +1,3 @@ | |||
| # NOTE: comment out before publishing - the binaries need to be uploaded | |||
There was a problem hiding this comment.
I feel like some of the process here should be documented somewhere?
There was a problem hiding this comment.
all "before publishing" are covered by the release notes.
I've also added ios/README.md, moving info from the podspec and expanding upon it to make the dev's life easier.
2 participants
Brings iOS support (tested on example/flutter/objectbox_demo). Fixes #47
Currently doesn't work properly because it requires objectbox-swift sourcedObjectBox.frameworkto be extracted in the ios folder to build correctly. Depends on flutter/flutter#45778While the issue is still open, we can circumvent it by packaging the
ObjectBox.frameworkdirectly when publishing to pub.dev. That's what this PR currently does.