Skip to content

Atc make dfs/bfs and getChildren optional (Should not affect gh-book)#102

Merged
philschatz merged 1 commit intomasterfrom
atc-dfs-optional
Nov 4, 2013
Merged

Atc make dfs/bfs and getChildren optional (Should not affect gh-book)#102
philschatz merged 1 commit intomasterfrom
atc-dfs-optional

Conversation

@philschatz
Copy link
Member

@philschatz philschatz commented Oct 31, 2013

Folders do not use TocPointerNode so they do not have a tree structure.

@philschatz
make dfs/bfs and getChildren optional
9c88431 
Folders to not use TocPointerNode so they do not have a tree structure
@philschatz philschatz mentioned this pull request Nov 1, 2013
Merged
3 tasks
@kathi-fletcher
Copy link
Member

kathi-fletcher commented Nov 3, 2013

I don't know if it is this things fault, but I got POST https://api.github.com/repos/oerpub/test-book/git/trees 422 (Unprocessable Entity) jquery.js:8434
POST https://api.github.com/repos/oerpub/test-book/git/trees 422 (Unprocessable Entity) jquery.js:8434
POST https://api.github.com/repos/oerpub/test-book/git/trees 422 (Unprocessable Entity) jquery.js:8434
POST https://api.github.com/repos/oerpub/test-book/git/trees 422 (Unprocessable Entity)

When I tried to save a file. I didn't have another window open with this repo.

@kathi-fletcher
Copy link
Member

kathi-fletcher commented Nov 3, 2013

Almost certainly not due to this PR, so
🍰 from testing. Don't merge until release branch made.
Also this still needs developer review.

@TomWoodward
Copy link
Member

TomWoodward commented Nov 4, 2013

🍰

philschatz added a commit that referenced this pull request Nov 4, 2013
@philschatz
Merge pull request #102 from oerpub/atc-dfs-optional
932af16 
Atc make dfs/bfs and getChildren optional (Should not affect gh-book)
@philschatz philschatz merged commit 932af16 into master Nov 4, 2013
@philschatz philschatz deleted the atc-dfs-optional branch November 4, 2013 22:28
@kathi-fletcher
Copy link
Member

kathi-fletcher commented Nov 5, 2013

hey -- did someone make the release branch of master?? before these got
merged? I was waiting on testing the table stuff to make that branch.

On Mon, Nov 4, 2013 at 4:28 PM, Philip Schatz [email protected]:

Merged #102 #102.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/102
.

Katherine Fletcher, [email protected]
[email protected]
Twitter: kefletcher http://www.twitter.com/kefletcher Blog:
kefletcher.blogspot.com
[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@philschatz @kathi-fletcher @TomWoodward