Skip to content

CLI: restore and harden qr --remote pairing behavior#18166

Merged
mbelinky merged 2 commits intomainfrom
port/gateway-cli-qr-remote-pairing
Feb 16, 2026
Merged

CLI: restore and harden qr --remote pairing behavior#18166
mbelinky merged 2 commits intomainfrom
port/gateway-cli-qr-remote-pairing

Conversation

@mbelinky
Copy link
Contributor

@mbelinky mbelinky commented Feb 16, 2026

Summary

Ports CLI QR remote pairing behavior restoration from ios-new-alpha-core onto main.

Included

  • openclaw qr --remote behavior restoration in current main-line implementation
  • Keeps existing remote precedence/auth handling already present on main

Scope

  • CLI QR files only

Testing

  • pnpm exec vitest run src/cli/qr-cli.test.ts src/pairing/setup-code.test.ts --maxWorkers 1
  • Result: pass
  • register.subclis.e2e broad script path was intentionally not run to keep targeted serial scope

Greptile Summary

Restored and hardened QR remote pairing behavior by adding early validation for the --remote flag. When --remote is specified without URL overrides, the code now validates that either gateway.remote.url or tailscale serve/funnel mode is configured before proceeding. This prevents the command from failing later in the resolution process and provides a clearer error message to users.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes add defensive validation logic with proper test coverage. The validation aligns correctly with the underlying URL resolution logic in setup-code.ts. No logical errors, security issues, or edge cases were identified.
  • No files require special attention

Last reviewed commit: efe7d9e

@mbelinky mbelinky self-assigned this Feb 16, 2026
@openclaw-barnacle openclaw-barnacle bot added cli CLI command changes size: XS maintainer Maintainer-authored PR labels Feb 16, 2026
@github-actions
Copy link
Contributor

⚠️ Formal models conformance drift detected

The formal models extracted constants (generated/*) do not match this openclaw PR.

This check is informational (not blocking merges yet).
See the formal-models-conformance-drift artifact for the diff.

If this change is intentional, follow up by updating the formal models repo or regenerating the extracted artifacts there.

@mbelinky mbelinky force-pushed the port/gateway-cli-qr-remote-pairing branch from efe7d9e to a79fc2a Compare February 16, 2026 15:36
@github-actions
Copy link
Contributor

⚠️ Formal models conformance drift detected

The formal models extracted constants (generated/*) do not match this openclaw PR.

This check is informational (not blocking merges yet).
See the formal-models-conformance-drift artifact for the diff.

If this change is intentional, follow up by updating the formal models repo or regenerating the extracted artifacts there.

@mbelinky mbelinky merged commit 68e39cf into main Feb 16, 2026
24 checks passed
@mbelinky mbelinky deleted the port/gateway-cli-qr-remote-pairing branch February 16, 2026 15:38
@mbelinky
Copy link
Contributor Author

Merged via squash.

Thanks @mbelinky!

archerhpagent pushed a commit to howardpark/openclaw that referenced this pull request Feb 18, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr.

Prepared head SHA: a79fc2a
Co-authored-by: mbelinky <[email protected]>
Co-authored-by: mbelinky <[email protected]>
Reviewed-by: @mbelinky
zooqueen pushed a commit to hanzoai/bot that referenced this pull request Mar 6, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr.

Prepared head SHA: a79fc2a
Co-authored-by: mbelinky <[email protected]>
Co-authored-by: mbelinky <[email protected]>
Reviewed-by: @mbelinky
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli CLI command changes maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant