fix(ios): restore missing location monitor merge files by ngutman · Pull Request #18260 · openclaw/openclaw

ngutman · 2026-02-16T17:06:53Z

Summary

Problem: NodeAppModel referenced SignificantLocationMonitor.startIfNeeded(...), but merge to main missed the corresponding iOS location monitor files/protocol methods.
Why it matters: pnpm ios:build failed with cannot find 'SignificantLocationMonitor' in scope.
What changed: restored iOS location monitor implementation and protocol surface from ios-new-alpha-core, plus the Info.plist ATS key used there.
What did NOT change (scope boundary): no changes to Android/macOS logic, no dependency updates.

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Closes #
Related #

User-visible / Behavior Changes

iOS build is restored for the missing location monitor merge case.
iOS Info.plist ATS key now uses NSAllowsArbitraryLoadsInWebContent (as in ios-new-alpha-core).

Security Impact (required)

New permissions/capabilities? (No)
Secrets/tokens handling changed? (No)
New/changed network calls? (No)
Command/tool execution surface changed? (No)
Data access scope changed? (No)
If any Yes, explain risk + mitigation:

Repro + Verification

Environment

OS: macOS
Runtime/container: local Xcode toolchain
Model/provider: N/A
Integration/channel (if any): iOS app
Relevant config (redacted): default iOS simulator destination

Steps

Check out branch.
Run pnpm ios:build.

Expected

Build completes successfully.

Actual

Build completes successfully (** BUILD SUCCEEDED **).

Evidence

Failing test/log before + passing after
Trace/log snippets
Screenshot/recording
Perf numbers (if relevant)

Human Verification (required)

Verified scenarios: restored files from ios-new-alpha-core, rebuilt iOS app.
Edge cases checked: confirmed build succeeds after adding @MainActor to StatusActivityBuilder.build under Swift 6 actor isolation.
What you did not verify: runtime behavior on physical iOS device.

Compatibility / Migration

Backward compatible? (Yes)
Config/env changes? (No)
Migration needed? (No)
If yes, exact upgrade steps:

Failure Recovery (if this breaks)

How to disable/revert this change quickly: revert this PR.
Files/config to restore:
- apps/ios/Sources/Info.plist
- apps/ios/Sources/Location/LocationService.swift
- apps/ios/Sources/Location/SignificantLocationMonitor.swift
- apps/ios/Sources/Services/NodeServiceProtocols.swift
- apps/ios/Sources/Status/StatusActivityBuilder.swift
Known bad symptoms reviewers should watch for:
- iOS compile failure referencing SignificantLocationMonitor
- actor isolation compile errors in StatusActivityBuilder

Risks and Mitigations

Risk: restoring ATS key behavior may differ from local-network-only setting.
- Mitigation: matches existing ios-new-alpha-core behavior and is scoped to iOS Info.plist only.

Greptile Summary

This PR restores iOS location monitor files (SignificantLocationMonitor.swift) and protocol methods that were missing after a merge to main, fixing the build failure. The implementation adds location monitoring functionality to track significant location changes and push events to the gateway for severance hook processing.

Key changes:

restored SignificantLocationMonitor enum with startIfNeeded() method referenced by NodeAppModel
added protocol methods in LocationServicing for location streaming and significant change monitoring
extended LocationService with callback-based and stream-based location monitoring
changed Info.plist ATS key from NSAllowsLocalNetworking to NSAllowsArbitraryLoadsInWebContent to match ios-new-alpha-core
marked StatusActivityBuilder.build as @MainActor to satisfy Swift 6 actor isolation

The restored implementation appears to match the original from ios-new-alpha-core. One logic issue was identified where stopping location stream updates could interfere with callback-based significant change monitoring when both are active simultaneously.

Confidence Score: 4/5

This PR is safe to merge with one logic issue that should be addressed
The PR successfully restores missing files from a merge and fixes the build. The implementation is straightforward file restoration from ios-new-alpha-core. Score reduced from 5 to 4 due to a state management issue in LocationService.stopLocationUpdates() where stopping stream updates could inadvertently stop callback-based significant change monitoring when both mechanisms are active
Pay attention to apps/ios/Sources/Location/LocationService.swift for the state management fix in stopLocationUpdates()

_{Last reviewed commit: 9c0974a}

github-actions · 2026-02-16T17:08:29Z

⚠️ Formal models conformance drift detected

The formal models extracted constants (generated/*) do not match this openclaw PR.

This check is informational (not blocking merges yet).
See the formal-models-conformance-drift artifact for the diff.

If this change is intentional, follow up by updating the formal models repo or regenerating the extracted artifacts there.

greptile-apps

_{5 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-16T17:09:29Z

apps/ios/Sources/Location/LocationService.swift

+    func stopLocationUpdates() {
+        guard self.isStreaming else { return }
+        self.isStreaming = false
+        self.manager.stopUpdatingLocation()
+        self.manager.stopMonitoringSignificantLocationChanges()
+        self.updatesContinuation?.finish()
+        self.updatesContinuation = nil
+    }


calling manager.stopMonitoringSignificantLocationChanges() here will also stop significant location monitoring started via startMonitoringSignificantLocationChanges() (line 147-151), even when isMonitoringSignificantChanges is true

Suggested change

func stopLocationUpdates() {

guard self.isStreaming else { return }

self.isStreaming = false

self.manager.stopUpdatingLocation()

self.manager.stopMonitoringSignificantLocationChanges()

self.updatesContinuation?.finish()

self.updatesContinuation = nil

}

func stopLocationUpdates() {

guard self.isStreaming else { return }

self.isStreaming = false

self.manager.stopUpdatingLocation()

if !self.isMonitoringSignificantChanges {

self.manager.stopMonitoringSignificantLocationChanges()

}

self.updatesContinuation?.finish()

self.updatesContinuation = nil

}

Prompt To Fix With AI

This is a comment left during a code review. Path: apps/ios/Sources/Location/LocationService.swift Line: 138:145 Comment: calling `manager.stopMonitoringSignificantLocationChanges()` here will also stop significant location monitoring started via `startMonitoringSignificantLocationChanges()` (line 147-151), even when `isMonitoringSignificantChanges` is true ```suggestion func stopLocationUpdates() { guard self.isStreaming else { return } self.isStreaming = false self.manager.stopUpdatingLocation() if !self.isMonitoringSignificantChanges { self.manager.stopMonitoringSignificantLocationChanges() } self.updatesContinuation?.finish() self.updatesContinuation = nil } ``` How can I resolve this? If you propose a fix, please make it concise.

…ngutman

…ngutman

github-actions · 2026-02-16T17:34:15Z

⚠️ Formal models conformance drift detected

The formal models extracted constants (generated/*) do not match this openclaw PR.

This check is informational (not blocking merges yet).
See the formal-models-conformance-drift artifact for the diff.

If this change is intentional, follow up by updating the formal models repo or regenerating the extracted artifacts there.

…ngutman

…ngutman

…ngutman

…ngutman

github-actions · 2026-02-16T17:38:06Z

⚠️ Formal models conformance drift detected

The formal models extracted constants (generated/*) do not match this openclaw PR.

This check is informational (not blocking merges yet).
See the formal-models-conformance-drift artifact for the diff.

If this change is intentional, follow up by updating the formal models repo or regenerating the extracted artifacts there.

github-actions · 2026-02-16T17:39:49Z

⚠️ Formal models conformance drift detected

The formal models extracted constants (generated/*) do not match this openclaw PR.

This check is informational (not blocking merges yet).
See the formal-models-conformance-drift artifact for the diff.

If this change is intentional, follow up by updating the formal models repo or regenerating the extracted artifacts there.

…ngutman

…ngutman

…ngutman

…ngutman

github-actions · 2026-02-16T17:43:06Z

⚠️ Formal models conformance drift detected

The formal models extracted constants (generated/*) do not match this openclaw PR.

This check is informational (not blocking merges yet).
See the formal-models-conformance-drift artifact for the diff.

If this change is intentional, follow up by updating the formal models repo or regenerating the extracted artifacts there.

@ngutman

Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: f60cd10 Co-authored-by: ngutman <[email protected]> Co-authored-by: ngutman <[email protected]> Reviewed-by: @ngutman

@ngutman

Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: f60cd10 Co-authored-by: ngutman <[email protected]> Co-authored-by: ngutman <[email protected]> Reviewed-by: @ngutman (cherry picked from commit 5a39e13) # Conflicts: # CHANGELOG.md # apps/ios/Sources/Info.plist # apps/ios/Sources/Status/StatusActivityBuilder.swift

@ngutman

Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: f60cd10 Co-authored-by: ngutman <[email protected]> Co-authored-by: ngutman <[email protected]> Reviewed-by: @ngutman (cherry picked from commit 5a39e13) # Conflicts: # CHANGELOG.md # apps/ios/Sources/Info.plist # apps/ios/Sources/Status/StatusActivityBuilder.swift

@ngutman

Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: f60cd10 Co-authored-by: ngutman <[email protected]> Co-authored-by: ngutman <[email protected]> Reviewed-by: @ngutman

openclaw-barnacle bot added app: ios App: ios size: S maintainer Maintainer-authored PR labels Feb 16, 2026

greptile-apps bot reviewed Feb 16, 2026

View reviewed changes

ngutman added a commit that referenced this pull request Feb 16, 2026

fix(changelog): document ios location monitor restore #18260 thanks @…

cdb8a10

…ngutman

ngutman force-pushed the fix/ios-restore-location-monitor branch from 9c0974a to cdb8a10 Compare February 16, 2026 17:32

ngutman added a commit that referenced this pull request Feb 16, 2026

fix(changelog): document ios location monitor restore #18260 thanks @…

bb4c6ea

…ngutman

ngutman force-pushed the fix/ios-restore-location-monitor branch from cdb8a10 to bb4c6ea Compare February 16, 2026 17:36

ngutman added a commit that referenced this pull request Feb 16, 2026

fix(changelog): document ios location monitor restore #18260 thanks @…

ec7d390

…ngutman

ngutman force-pushed the fix/ios-restore-location-monitor branch from bb4c6ea to ec7d390 Compare February 16, 2026 17:38

ngutman added a commit that referenced this pull request Feb 16, 2026

fix(changelog): document ios location monitor restore #18260 thanks @…

14b688d

…ngutman

ngutman force-pushed the fix/ios-restore-location-monitor branch from ec7d390 to 14b688d Compare February 16, 2026 17:39

ngutman added 3 commits February 16, 2026 19:40

fix(ios): restore missing significant location monitor files

d458fed

fix(ios): mark status activity builder as main actor

c710029

fix(changelog): document ios location monitor restore #18260 thanks @…

f60cd10

…ngutman

ngutman force-pushed the fix/ios-restore-location-monitor branch from 14b688d to f60cd10 Compare February 16, 2026 17:41

ngutman merged commit 5a39e13 into main Feb 16, 2026
13 checks passed

ngutman deleted the fix/ios-restore-location-monitor branch February 16, 2026 17:41

github-actions bot mentioned this pull request Feb 16, 2026

📡 Upstream Digest — 2026-02-16 18:33 UTC curtismercier/openclaw-mods#45

Open

github-actions bot mentioned this pull request Mar 1, 2026

cherry-pick: upstream docs commits (2026-03-01-0443) hughdidit/DAISy-Agency#141

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(ios): restore missing location monitor merge files#18260

fix(ios): restore missing location monitor merge files#18260
ngutman merged 3 commits intomainfrom
fix/ios-restore-location-monitor

ngutman commented Feb 16, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Feb 16, 2026

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

ngutman commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

User-visible / Behavior Changes

Security Impact (required)

Repro + Verification

Environment

Steps

Expected

Actual

Evidence

Human Verification (required)

Compatibility / Migration

Failure Recovery (if this breaks)

Risks and Mitigations

Greptile Summary

Confidence Score: 4/5

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ngutman commented Feb 16, 2026 •

edited

Loading