Fix/Complete LINE `requireMention` gating behavior by kirisame-wang · Pull Request #35847 · openclaw/openclaw

kirisame-wang · 2026-03-05T09:30:36Z

Summary

Problem: LINE's requireMention config is fully ignored in group/room chats — no mention gating, no pending history, and LINE missing from the DOCKS registry.
Why it matters: 100% reproducible — bot replies to every group message regardless of config. A documented setting silently does nothing.
What changed: Extends fix(line): enforce requireMention gating in group messages #34469's gating implementation with seven follow-up fixes:
1. Register LINE in DOCKS, CHAT_CHANNEL_ORDER, and CHAT_CHANNEL_META so the reply-stage resolveGroupRequireMention reads LINE config correctly
2. Default requireMention to true (consistent with all other channels); add mentionPatterns regex fallback alongside native isSelf/@All detection; record unmentioned messages via recordPendingHistoryEntryIfEnabled
3. Tests: add requireMention: false to 6 existing unrelated group tests; add tests for default-skip and pending history recording
4. Fix historyKey sentinel — use undefined instead of empty string
5. Deliver pending history via InboundHistory to finalizeInboundContext instead of mutating ctxPayload.Body (which is overridden by BodyForAgent in the prompt pipeline)
6. Pass agentId to buildMentionRegexes so per-agent mentionPatterns are respected in multi-agent LINE routing
7. Clear groupHistories after each handled group turn to prevent stale messages from replaying on subsequent mentions
What did NOT change: DM behavior, postback handling, other channel flows, config schema.

Change Type (select all)

Bug fix

Scope (select all touched areas)

Gateway / orchestration
Integrations

Linked Issue/PR

Closes LINE plugin: group mention gating (requireMention / mentionPatterns) has no effect #16975
Closes LINE plugin: group requireMention / mentionPatterns not enforced #29746
Closes [Bug]: LINE channel requireMention setting has no effect #34438 — this PR is the direct implementation of the root cause analysis and fix design documented in that issue
Related fix(line): enforce LINE group mention gating #29786, line: enforce requireMention for group text events #34447
Based on fix(line): enforce requireMention gating in group messages #34469 by @RealKai42 — this PR builds on that foundation and adds the remaining fixes identified in review (see Fix/Complete LINE requireMention gating behavior RealKai42/openclaw#1)

User-visible / Behavior Changes

requireMention now defaults to true for LINE groups (consistent with all other channels). Migration: add requireMention: false to any LINE group config that should respond to all messages.
Unmentioned messages accumulate as pending history and are injected when the bot is later @mentioned.
mentionPatterns now works for LINE groups.

Security Impact (required)

New permissions/capabilities? No
Secrets/tokens handling changed? No
New/changed network calls? No
Command/tool execution surface changed? No
Data access scope changed? No

Repro + Verification

Environment

OS: Debian GNU/Linux 12
Runtime/container: Node.js v22
Integration/channel: LINE (group/room)

Steps

Configure a LINE group with requireMention: true
Send messages in the group without mentioning the bot
Send a message @mentioning the bot

Expected

Steps 1–2: no reply; messages recorded as pending history
Step 3: bot replies with context from preceding conversation

Actual (before)

Bot replies to every message; requireMention has no effect

Evidence

New and updated tests in bot-handlers.test.ts

New tests (mention gating + pending history):

skips group messages without mention when requireMention is set
processes group messages with bot mention when requireMention is set (native isSelf)
processes group messages with @all mention when requireMention is set (type: "all")
does not apply requireMention gating to DM messages
allows non-text group messages through when requireMention is set (cannot detect mention)
does not bypass mention gating when non-bot mention is present with control command
skips group messages by default when requireMention is not configured
records unmentioned group messages as pending history

Existing tests updated (6):

Added requireMention: false to allowlist, replay dedup, inflight dedup, and error retry group tests — preserves original intent after default changed from false to true

Human Verification (required)

Verified scenarios: gating skip, pending history record/inject/clear, DM passthrough, non-text passthrough, @All, mentionPatterns, command bypass, per-agent agentId, live LINE environment end-to-end
What I did not verify: postback in group with requireMention: true

Compatibility / Migration

Backward compatible? No — requireMention default changes to true
Config/env changes? Yes
Migration needed? Yes — add requireMention: false to LINE group configs that should respond to all messages

Failure Recovery (if this breaks)

Quick revert: set requireMention: false on affected LINE group configs, or revert bot-handlers.ts / bot-message-context.ts
Bad symptoms: bot silent in all LINE groups → check requireMention config

Risks and Mitigations

Risk: default change breaks existing LINE group deployments
- Mitigation: one-line config fix; matches all other channel defaults; documented in migration note
Risk: pending history is in-memory and lost on restart
- Mitigation: matches existing pattern for Telegram, Signal, iMessage, Webchat

greptile-apps · 2026-03-05T09:37:09Z

Greptile Summary

This PR fixes a long-standing bug where LINE's requireMention config was fully ignored in group/room chats, causing the bot to reply to every group message regardless of configuration. The fix is well-scoped: it registers LINE in the channel registry/docks, implements mention gating (native isSelf/@All + mentionPatterns regex fallback) using the shared resolveMentionGatingWithBypass helper, records un-gated messages as pending history, delivers that history via InboundHistory on the next mention, and clears it afterwards.

Key observations:

The core gating logic is correct and consistent with how Telegram, Slack, iMessage, and other channels handle requireMention
The breaking default change (requireMention now defaults to true for LINE groups) is clearly documented and handled in tests; existing users need to add requireMention: false to opt back into the old behaviour
Two minor style issues found: an orphaned JSDoc block above getLineMentionees and import ordering breaking the local/external import grouping convention
Postback events in group chats intentionally bypass requireMention gating (acknowledged in the PR description as "What did NOT change: postback handling"), but worth being aware of if this config is relied upon for full group gating

Confidence Score: 4/5

Safe to merge. The gating implementation is correct and well-tested; the two remaining findings are non-blocking style issues.
The functional logic is sound — mention gating, pending history recording, and history clearing all work correctly. Tests verify the key scenarios. The breaking default change is clearly documented. The only issues are two style/organization matters that don't affect correctness: a duplicate JSDoc comment and an import ordering inconsistency. These are worth fixing but not blocking.
src/line/bot-handlers.ts — two minor style issues (orphaned JSDoc and import ordering)

_{Last reviewed commit: ab90e32}

src/line/bot-handlers.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ab90e32f32

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/line/bot.ts

src/line/bot-handlers.ts

- Move resolveAgentRoute import from ./local group to ../routing group - Merge duplicate JSDoc blocks above getLineMentionees into one Addresses Greptile review comments r2888826724 and r2888826840 on PR openclaw#35847. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

- bot.ts: resolve historyLimit from cfg.messages.groupChat.historyLimit with fallback to DEFAULT_GROUP_HISTORY_LIMIT, so setting historyLimit: 0 actually disables pending history accumulation - bot-handlers.ts: add groupHistories.has(historyKey) guard before clearHistoryEntriesIfEnabled to prevent writing empty buckets for groups that have never accumulated pending history (memory leak) Addresses Codex review comments r2888829146 and r2888829152 on PR openclaw#35847. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

Auto-formatted by oxfmt to fix CI format:check failure on PR openclaw#35847. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ff4f75063f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/line/bot-handlers.ts

kirisame-wang · 2026-03-07T10:50:52Z

We've completed end-to-end testing of this fix in a real LINE group chat. Here's what was verified:

Test Scenarios:

Scenario	Expected	Result
`requireMention: true` — message sent without mention	Bot stays silent, accumulates pending history	✅ Pass
`requireMention: true` — message sent with `@Clawbit` mention	Bot responds with accumulated group context	✅ Pass
`requireMention: false` — message sent without mention	Bot responds normally to all messages	✅ Pass

Pending History behavior (requireMention: true):

When requireMention: true is set, the bot does not simply ignore messages — it continues to record group messages as pending history in the background. Once the bot is @mentioned, it responds with the full accumulated context since the last reply, preserving conversational continuity.

Screenshot 1 — requireMention: true:

A user asked a math question ("Do you know 1 plus 3 equal to?") — bot correctly stayed silent while recording the message.

Another user then explicitly mentioned @Clawbit asking it to answer — bot responded correctly with context.

A follow-up @Clawbit mention for a spelling check — bot also responded as expected.

Screenshot 2 — requireMention: false:

User said "hello" without any mention — bot responded immediately.

User asked for a joke without mention — bot responded with a crab joke.

User said "Thanks" without mention — bot replied naturally.

Both modes are confirmed to be working as intended.

- Add "line" to CHAT_CHANNEL_ORDER and CHAT_CHANNEL_META in registry.ts - Export resolveLineGroupRequireMention and resolveLineGroupToolPolicy in group-mentions.ts using the generic resolveChannelGroupRequireMention and resolveChannelGroupToolsPolicy helpers (same pattern as iMessage) - Add "line" entry to DOCKS in dock.ts so resolveGroupRequireMention in the reply stage can correctly read LINE group config Fixes the third layer of the requireMention bug: previously getChannelDock("line") returned undefined, causing the reply-stage resolveGroupRequireMention to fall back to true unconditionally. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

…allback - Default requireMention to true (consistent with other channels) - Add mentionPatterns regex fallback alongside native isSelf/@ALL detection - Record unmentioned group messages via recordPendingHistoryEntryIfEnabled - Inject pending history context in buildLineMessageContext when bot is mentioned Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

- Add requireMention: false to 6 group tests unrelated to mention gating (allowlist, replay dedup, inflight dedup, error retry) to preserve their original intent after the default changed from false to true - Add test: skips group messages by default when requireMention not configured - Add test: records unmentioned group messages as pending history Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

- Remove post-hoc ctxPayload.Body injection (BodyForAgent takes priority in the prompt pipeline, so Body was never reached) - Pass InboundHistory array to finalizeInboundContext instead, matching the Telegram pattern rendered by buildInboundUserContextPrefix Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

…atterns - Resolve route before mention gating to obtain agentId - Pass agentId to buildMentionRegexes, matching Telegram behavior Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

- Call clearHistoryEntriesIfEnabled after processMessage for group messages - Prevents stale skipped messages from replaying on subsequent mentions - Matches Discord, Signal, Slack, iMessage behavior Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

- Move resolveAgentRoute import from ./local group to ../routing group - Merge duplicate JSDoc blocks above getLineMentionees into one Addresses Greptile review comments r2888826724 and r2888826840 on PR openclaw#35847. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

- bot.ts: resolve historyLimit from cfg.messages.groupChat.historyLimit with fallback to DEFAULT_GROUP_HISTORY_LIMIT, so setting historyLimit: 0 actually disables pending history accumulation - bot-handlers.ts: add groupHistories.has(historyKey) guard before clearHistoryEntriesIfEnabled to prevent writing empty buckets for groups that have never accumulated pending history (memory leak) Addresses Codex review comments r2888829146 and r2888829152 on PR openclaw#35847. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

Auto-formatted by oxfmt to fix CI format:check failure on PR openclaw#35847. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

resolveAgentRoute calls shouldLogVerbose() from globals.js; the mock was missing this export, causing 13 test failures. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

randyjtw · 2026-03-07T20:14:03Z

Follow-up for traceability: duplicate/superseded PRs have now been closed:\n- #35766\n- #35765\n- #34447\n\nKeeping all implementation and review history consolidated in this merged PR.

randyjtw · 2026-03-07T20:15:45Z

為便於追溯，以下重複／被取代的 PR 已關閉：

相關實作與審查紀錄已統一整理於本 PR。

kirisame-wang · 2026-03-08T01:45:45Z

Thanks to all the reviewers, and special thanks to @randyjtw.

* fix(line): enforce requireMention gating in group message handler * fix(line): scope canDetectMention to text messages, pass hasAnyMention * fix(line): fix TS errors in mentionees type and test casts * feat(line): register LINE in DOCKS and CHAT_CHANNEL_ORDER - Add "line" to CHAT_CHANNEL_ORDER and CHAT_CHANNEL_META in registry.ts - Export resolveLineGroupRequireMention and resolveLineGroupToolPolicy in group-mentions.ts using the generic resolveChannelGroupRequireMention and resolveChannelGroupToolsPolicy helpers (same pattern as iMessage) - Add "line" entry to DOCKS in dock.ts so resolveGroupRequireMention in the reply stage can correctly read LINE group config Fixes the third layer of the requireMention bug: previously getChannelDock("line") returned undefined, causing the reply-stage resolveGroupRequireMention to fall back to true unconditionally. Co-Authored-By: Claude Sonnet 4.6 <[email protected]> * fix(line): pending history, requireMention default, mentionPatterns fallback - Default requireMention to true (consistent with other channels) - Add mentionPatterns regex fallback alongside native isSelf/@ALL detection - Record unmentioned group messages via recordPendingHistoryEntryIfEnabled - Inject pending history context in buildLineMessageContext when bot is mentioned Co-Authored-By: Claude Sonnet 4.6 <[email protected]> * test(line): update tests for requireMention default and pending history - Add requireMention: false to 6 group tests unrelated to mention gating (allowlist, replay dedup, inflight dedup, error retry) to preserve their original intent after the default changed from false to true - Add test: skips group messages by default when requireMention not configured - Add test: records unmentioned group messages as pending history Co-Authored-By: Claude Sonnet 4.6 <[email protected]> * fix(line): use undefined instead of empty string as historyKey sentinel Co-Authored-By: Claude Sonnet 4.6 <[email protected]> * fix(line): deliver pending history via InboundHistory, not Body mutation - Remove post-hoc ctxPayload.Body injection (BodyForAgent takes priority in the prompt pipeline, so Body was never reached) - Pass InboundHistory array to finalizeInboundContext instead, matching the Telegram pattern rendered by buildInboundUserContextPrefix Co-Authored-By: Claude Sonnet 4.6 <[email protected]> * fix(line): pass agentId to buildMentionRegexes for per-agent mentionPatterns - Resolve route before mention gating to obtain agentId - Pass agentId to buildMentionRegexes, matching Telegram behavior Co-Authored-By: Claude Sonnet 4.6 <[email protected]> * fix(line): clear pending history after handled group turn - Call clearHistoryEntriesIfEnabled after processMessage for group messages - Prevents stale skipped messages from replaying on subsequent mentions - Matches Discord, Signal, Slack, iMessage behavior Co-Authored-By: Claude Sonnet 4.6 <[email protected]> * style(line): fix import order and merge orphaned JSDoc in bot-handlers - Move resolveAgentRoute import from ./local group to ../routing group - Merge duplicate JSDoc blocks above getLineMentionees into one Addresses Greptile review comments r2888826724 and r2888826840 on PR openclaw#35847. Co-Authored-By: Claude Sonnet 4.6 <[email protected]> * fix(line): read historyLimit from config and guard clear with has() - bot.ts: resolve historyLimit from cfg.messages.groupChat.historyLimit with fallback to DEFAULT_GROUP_HISTORY_LIMIT, so setting historyLimit: 0 actually disables pending history accumulation - bot-handlers.ts: add groupHistories.has(historyKey) guard before clearHistoryEntriesIfEnabled to prevent writing empty buckets for groups that have never accumulated pending history (memory leak) Addresses Codex review comments r2888829146 and r2888829152 on PR openclaw#35847. Co-Authored-By: Claude Sonnet 4.6 <[email protected]> * style(line): apply oxfmt formatting to bot-handlers and bot Auto-formatted by oxfmt to fix CI format:check failure on PR openclaw#35847. Co-Authored-By: Claude Sonnet 4.6 <[email protected]> * fix(line): add shouldLogVerbose to globals mock in bot-handlers test resolveAgentRoute calls shouldLogVerbose() from globals.js; the mock was missing this export, causing 13 test failures. Co-Authored-By: Claude Sonnet 4.6 <[email protected]> * Address review findings for openclaw#35847 --------- Co-authored-by: Kaiyi <[email protected]> Co-authored-by: Claude Sonnet 4.6 <[email protected]> Co-authored-by: Yi-Cheng Wang <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

openclaw-barnacle bot added the size: M label Mar 5, 2026

greptile-apps bot reviewed Mar 5, 2026

View reviewed changes

src/line/bot-handlers.ts Outdated Show resolved Hide resolved

src/line/bot-handlers.ts Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 5, 2026

View reviewed changes

src/line/bot.ts Outdated Show resolved Hide resolved

src/line/bot-handlers.ts Show resolved Hide resolved

openclaw-barnacle bot added size: L and removed size: M labels Mar 5, 2026

chatgpt-codex-connector bot reviewed Mar 5, 2026

View reviewed changes

src/line/bot-handlers.ts Show resolved Hide resolved

kirisame-wang mentioned this pull request Mar 5, 2026

[Bug]: LINE channel requireMention setting has no effect #34438

Closed

Takhoffman self-assigned this Mar 7, 2026

Kaiyi and others added 15 commits March 7, 2026 13:47

fix(line): enforce requireMention gating in group message handler

9b98777

fix(line): scope canDetectMention to text messages, pass hasAnyMention

d175058

fix(line): fix TS errors in mentionees type and test casts

df570c2

fix(line): use undefined instead of empty string as historyKey sentinel

0165329

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

fix(line): pass agentId to buildMentionRegexes for per-agent mentionP…

3a4a29a

…atterns - Resolve route before mention gating to obtain agentId - Pass agentId to buildMentionRegexes, matching Telegram behavior Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

style(line): apply oxfmt formatting to bot-handlers and bot

cd36930

Auto-formatted by oxfmt to fix CI format:check failure on PR openclaw#35847. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

fix(line): add shouldLogVerbose to globals mock in bot-handlers test

d5b71c3

resolveAgentRoute calls shouldLogVerbose() from globals.js; the mock was missing this export, causing 13 test failures. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

Address review findings for openclaw#35847

cfe7967

Takhoffman force-pushed the fix/complete-line-require-mention-gating branch from e8a511f to cfe7967 Compare March 7, 2026 19:57

Takhoffman merged commit 4682f3c into openclaw:main Mar 7, 2026
24 of 29 checks passed

This was referenced Mar 7, 2026

line: enforce requireMention for group text events #34447

Closed

fix(line): add mention gating for group messages / 修復 LINE 群組 requireMention 不生效 #35128

Closed

line: keep pending group history when requireMention is enabled #35766

Closed

randyjtw mentioned this pull request Mar 7, 2026

channels: add line to core chat registry and dock #35765

Closed

github-actions bot mentioned this pull request Mar 7, 2026

📡 Upstream Digest — 2026-03-07 20:17 UTC curtismercier/openclaw-mods#204

Open

alexey-pelykh mentioned this pull request Mar 10, 2026

Cherry-pick: upstream channel adapter updates (14 commits) remoteclaw/remoteclaw#866

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix/Complete LINE `requireMention` gating behavior#35847

Fix/Complete LINE `requireMention` gating behavior#35847
Takhoffman merged 15 commits intoopenclaw:mainfrom
kirisame-wang:fix/complete-line-require-mention-gating

kirisame-wang commented Mar 5, 2026 •

edited

Loading

Uh oh!

greptile-apps bot commented Mar 5, 2026

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

kirisame-wang commented Mar 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

randyjtw commented Mar 7, 2026

Uh oh!

randyjtw commented Mar 7, 2026

Uh oh!

kirisame-wang commented Mar 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

kirisame-wang commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

User-visible / Behavior Changes

Security Impact (required)

Repro + Verification

Environment

Steps

Expected

Actual (before)

Evidence

Human Verification (required)

Compatibility / Migration

Failure Recovery (if this breaks)

Risks and Mitigations

Uh oh!

greptile-apps bot commented Mar 5, 2026

Greptile Summary

Confidence Score: 4/5

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

kirisame-wang commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

randyjtw commented Mar 7, 2026

Uh oh!

randyjtw commented Mar 7, 2026

Uh oh!

kirisame-wang commented Mar 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kirisame-wang commented Mar 5, 2026 •

edited

Loading

kirisame-wang commented Mar 7, 2026 •

edited

Loading