feat: add configurable silence timeout#39607
Conversation
Greptile SummaryThis PR adds a configurable Key changes:
Minor issue: the CHANGELOG entry is missing a blank line before the Confidence Score: 4/5
Last reviewed commit: 3f0dccf |
CHANGELOG.md
Outdated
| - Talk mode: add top-level `talk.silenceTimeoutMs` config so Talk waits a configurable amount of silence before auto-sending the current transcript, while keeping each platform's existing default pause window when unset. Fixes #17147. | ||
| ### Fixes |
There was a problem hiding this comment.
Missing blank line before the ### Fixes section header. The new changelog entry should be followed by a blank line to match the spacing used elsewhere in the file and ensure proper markdown rendering.
| - Talk mode: add top-level `talk.silenceTimeoutMs` config so Talk waits a configurable amount of silence before auto-sending the current transcript, while keeping each platform's existing default pause window when unset. Fixes #17147. | |
| ### Fixes | |
| - Talk mode: add top-level `talk.silenceTimeoutMs` config so Talk waits a configurable amount of silence before auto-sending the current transcript, while keeping each platform's existing default pause window when unset. Fixes #17147. | |
| ### Fixes |
Prompt To Fix With AI
This is a comment left during a code review.
Path: CHANGELOG.md
Line: 9-10
Comment:
Missing blank line before the `### Fixes` section header. The new changelog entry should be followed by a blank line to match the spacing used elsewhere in the file and ensure proper markdown rendering.
```suggestion
- Talk mode: add top-level `talk.silenceTimeoutMs` config so Talk waits a configurable amount of silence before auto-sending the current transcript, while keeping each platform's existing default pause window when unset. Fixes #17147.
### Fixes
```
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
…nodoesdesign) Co-authored-by: dano does design <[email protected]>
3f0dccf to
43c395d
Compare
|
Landed via temp rebase onto main.
Thanks @danodoesdesign! |
* main: (70 commits) Refactor release hardening follow-ups (openclaw#39959) docs: clarify bot review conversation ownership (openclaw#39942) fix: harden talk silence timeout parsing (openclaw#39607) (thanks @danodoesdesign) talk: add configurable silence timeout transcript-policy: use named Set for anthropic signature-excluded providers transcript-policy: don't preserve thinking signatures for kimi-coding (openclaw#39798) fix: land mac universal release defaults (openclaw#33891) (thanks @cgdusek) Docs: clarify notarization handoff in mac release flow Docs: mark basic mac dist example as non-notarized Docs: clarify release build arch defaults for mac packaging macOS: default release app builds to universal binaries fix(issue-39839): address tool-call extra params parsing for kimi anthropic-messages docs: use alphabetical provider ordering fix: follow up openclaw#39321 and openclaw#38445 landings docs: note /landpr merge process fix: land Brave llm-context gaps (openclaw#33383) (thanks @thirumaleshp) feat: add Brave Search LLM Context API mode for web_search fix(feishu): restore @larksuiteoapi/node-sdk in root dependencies refactor: tighten codex inline api fallback follow-up macOS: set speech recognition taskHint for Talk Mode mic capture ...
…nodoesdesign) Co-authored-by: dano does design <[email protected]>
…nodoesdesign) Co-authored-by: dano does design <[email protected]>
…nodoesdesign) Co-authored-by: dano does design <[email protected]>
…nodoesdesign) Co-authored-by: dano does design <[email protected]>
上游更新摘要(abb8f6310 → bda63c3,164 commits): ### 新功能 - ACP: 新增 resumeSessionId 支持 ACP session 恢复(openclaw#41847) - CLI: 新增 openclaw backup create/verify 本地状态归档命令(openclaw#40163) - Talk: 新增 talk.silenceTimeoutMs 配置项,可自定义静默超时(openclaw#39607) - ACP Provenance: 新增 ACP 入站溯源元数据和回执注入(openclaw#40473) - Brave 搜索: 新增 llm-context 模式,返回 AI 精炼摘要(openclaw#33383) - browser.relayBindHost: Chrome relay 可绑定非 loopback 地址(WSL2 支持)(openclaw#39364) - node-pending-work: 新增 node.pending.pull/ack RPC 接口 - Telegram: 新增 exec-approvals 处理器,支持 Telegram 内命令执行审批 - Mattermost: 新增 target-resolution,修复 markdown 保留和 DM media 上传 - MS Teams: 修复 Bot Framework General channel 对话 ID 兼容性(openclaw#41838) - secrets/runtime-web-tools: 全新 web runtime secrets 工具模块 - cron: 新增 store-migration,isolated-agent 直送核心通道,delivery failure notify - TUI: 自动检测浅色终端主题(COLORFGBG),支持 OPENCLAW_THEME 覆盖(openclaw#38636) ### 修复 - macOS: launchd 重启前重启已禁用服务,修复 openclaw update 卡死问题 - Telegram DM: 按 agent 去重入站 DM,防止同一条消息触发重复回复(openclaw#40519) - Matrix DM: 修复 m.direct homeserver 检测,保留房间绑定优先级(openclaw#19736) - 飞书: 清理插件发现缓存,修复 onboarding 安装后重复弹窗(openclaw#39642) - config/runtime snapshots: 修复 config 写入后 secret 快照丢失问题(openclaw#37313) - browser/CDP: 修复 ws:// CDP URL 反向代理和 wildcard 地址重写 - agents/failover: 识别 Bedrock tokens per day 限额为 rate limit ### 版本 - ACPX 0.1.16 - iOS/macOS 版本号更新 - Android: 精简后台权限 构建验证:待执行
…nodoesdesign) Co-authored-by: dano does design <[email protected]>
…nodoesdesign) Co-authored-by: dano does design <[email protected]>
…nodoesdesign) Co-authored-by: dano does design <[email protected]> (cherry picked from commit 0af3118)
…nodoesdesign) (#1274) (cherry picked from commit 0af3118) Co-authored-by: Peter Steinberger <[email protected]> Co-authored-by: dano does design <[email protected]>
Summary
Forgive me, this is my first OSS contribution! I hope it is valuable.
Written 99% with codex via 5.4
Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
-- Feature Request: Configurable silence timeout in Talk Mode #17147
-- Feature request: Configurable idle timeout for Talk mode to return to wake word detection #4314 (Similar but different output intention)
User-visible / Behavior Changes
List user-visible changes (including defaults/config).
Security Impact (required)
No)No)No)No)No)Yes, explain risk + mitigation:Repro + Verification
Environment
Steps
Expected
Actual
Evidence
Attach at least one:
Unsure how to provide behavioural evidence for this sorry :S
Human Verification (required)
What you personally verified (not just CI), and how:
Compatibility / Migration
No, assumedly because config change)Yes)Unsure)Failure Recovery (if this breaks)
Risks and Mitigations
List only real risks for this PR. Add/remove entries as needed. If none, write
None.