fix(telegram): clear stale retain before transient final fallback#41763
Merged
fix(telegram): clear stale retain before transient final fallback#41763
Conversation
Contributor
Greptile SummaryThis PR fixes a subtle state-leak bug in Telegram's draft-stream delivery layer: Changes:
Confidence Score: 5/5
Last reviewed commit: 50646aa |
50646aa to
c094083
Compare
Contributor
Author
|
Merged via squash.
Thanks @obviyus! |
davidemanuelDEV
pushed a commit
to davidemanuelDEV/openclaw
that referenced
this pull request
Mar 11, 2026
…enclaw#41763) Merged via squash. Prepared head SHA: c094083 Co-authored-by: obviyus <[email protected]> Co-authored-by: obviyus <[email protected]> Reviewed-by: @obviyus
mrosmarin
added a commit
to mrosmarin/openclaw
that referenced
this pull request
Mar 11, 2026
* main: fix(agents): check billing errors before context overflow heuristics (openclaw#40409) fix(config): add missing editMessage and createForumTopic to Telegram actions schema (openclaw#35498) fix(signal): add missing accountUuid to Zod config schema (openclaw#35578) fix(voice-call): add speed and instructions to OpenAI TTS config schema (openclaw#39226) fix(telegram): clear stale retain before transient final fallback (openclaw#41763) Fix env proxy bootstrap for model traffic (openclaw#43248) fix: tighten Ollama onboarding cloud handling (openclaw#41529) (thanks @BruceMacD) Onboard: add Ollama auth flow and improve model defaults
dhoman
pushed a commit
to dhoman/chrono-claw
that referenced
this pull request
Mar 11, 2026
…enclaw#41763) Merged via squash. Prepared head SHA: c094083 Co-authored-by: obviyus <[email protected]> Co-authored-by: obviyus <[email protected]> Reviewed-by: @obviyus
hydro13
pushed a commit
to hydro13/openclaw
that referenced
this pull request
Mar 12, 2026
…enclaw#41763) Merged via squash. Prepared head SHA: c094083 Co-authored-by: obviyus <[email protected]> Co-authored-by: obviyus <[email protected]> Reviewed-by: @obviyus
Ruijie-Ysp
pushed a commit
to Ruijie-Ysp/clawdbot
that referenced
this pull request
Mar 12, 2026
…enclaw#41763) Merged via squash. Prepared head SHA: c094083 Co-authored-by: obviyus <[email protected]> Co-authored-by: obviyus <[email protected]> Reviewed-by: @obviyus
plabzzxx
pushed a commit
to plabzzxx/openclaw
that referenced
this pull request
Mar 13, 2026
…enclaw#41763) Merged via squash. Prepared head SHA: c094083 Co-authored-by: obviyus <[email protected]> Co-authored-by: obviyus <[email protected]> Reviewed-by: @obviyus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
retainPreviewOnCleanupByLanecould staytrueafter an archived-preview retain and leak into a later transient final on the same lane.sendPayload, cleanup skippedstream.clear()and left a stale partial preview next to the fallback-sent final message.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
Security Impact (required)
No)No)No)No)No)Yes, explain risk + mitigation:Repro + Verification
Environment
partialSteps
message to edit not found, then send message B as the active preview.sendPayload.Expected
Actual
Evidence
Human Verification (required)
What you personally verified (not just CI), and how:
src/telegram/lane-delivery.test.ts,src/telegram/bot-message-dispatch.test.ts, andsrc/telegram/network-errors.test.ts;pnpm tsgo.Review Conversations
Compatibility / Migration
Yes)No)No)Failure Recovery (if this breaks)
87bf43145.src/telegram/lane-delivery-text-deliverer.ts,src/telegram/bot-message-dispatch.test.tsRisks and Mitigations
activePreviewLifecycleByLane === "transient", and the existing finalized-preview regression still passes.