Updated default model from openai-codex/gpt-5.3-codex to openai-codex/gpt-5.4 in tests.#44367
Merged
dvrshil merged 2 commits intoopenclaw:mainfrom Mar 13, 2026
Merged
Conversation
Contributor
Greptile SummaryThis PR is a test-only chore that synchronizes two failing test assertions in Changes:
Confidence Score: 5/5
Last reviewed commit: 5adb355 |
dvrshil
approved these changes
Mar 13, 2026
Member
dvrshil
left a comment
dvrshil
left a comment
There was a problem hiding this comment.
Verified locally.
corepack pnpm vitest run src/commands/models/auth.test.ts currently fails in exactly the two stale assertions this PR updates:
Default model available: openai-codex/gpt-5.3-codex ...Default model set to openai-codex/gpt-5.3-codex
Current production default is already openai-codex/gpt-5.4 in src/commands/openai-codex-model-default.ts, so this keeps the test file aligned with shipped behavior without changing runtime code.
dvrshil
force-pushed
the
fix/openai-codex-auth-test
branch
2 times, most recently
from
c41b8fc to
bda9e28
Compare
- Updated default model from openai-codex/gpt-5.3-codex to openai-codex/gpt-5.4 in tests.
dvrshil
force-pushed
the
fix/openai-codex-auth-test
branch
from
bda9e28 to
c372ba6
Compare
Member
|
Merged via squash.
Thanks @jrrcdev! |
Closed
20 tasks
frankekn
pushed a commit
that referenced
this pull request
Mar 13, 2026
…/gpt-5.4 in tests. (#44367) Merged via squash. Prepared head SHA: c372ba6 Co-authored-by: jrrcdev <[email protected]> Co-authored-by: dvrshil <[email protected]> Reviewed-by: @dvrshil
frankekn
pushed a commit
to jmcte/openclaw
that referenced
this pull request
Mar 13, 2026
…/gpt-5.4 in tests. (openclaw#44367) Merged via squash. Prepared head SHA: c372ba6 Co-authored-by: jrrcdev <[email protected]> Co-authored-by: dvrshil <[email protected]> Reviewed-by: @dvrshil
Jerry-Xin
pushed a commit
to Jerry-Xin/openclaw
that referenced
this pull request
Mar 13, 2026
…/gpt-5.4 in tests. (openclaw#44367) Merged via squash. Prepared head SHA: c372ba6 Co-authored-by: jrrcdev <[email protected]> Co-authored-by: dvrshil <[email protected]> Reviewed-by: @dvrshil
ecochran76
pushed a commit
to ecochran76/openclaw
that referenced
this pull request
Mar 14, 2026
…/gpt-5.4 in tests. (openclaw#44367) Merged via squash. Prepared head SHA: c372ba6 Co-authored-by: jrrcdev <[email protected]> Co-authored-by: dvrshil <[email protected]> Reviewed-by: @dvrshil
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
models/auth.test.tsexpected the old default modelopenai-codex/gpt-5.3-codexand the old log text. The codebase default was alreadyopenai-codex/gpt-5.4(inopenai-codex-model-default.ts), so the tests were out of date and failing.src/commands/models/auth.test.ts, updated the two Codex login tests to assert onopenai-codex/gpt-5.4and the matching “Default model available” / “Default model set to” log messages.OPENAI_CODEX_DEFAULT_MODEL, no user-facing behavior, and no other test files.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
None. Test-only change; default model and CLI behavior are unchanged.
Security Impact (required)
Repro + Verification
Environment
Steps
npx vitest run src/commands/models/auth.test.ts.gpt-5.3-codex, receivedgpt-5.4).Expected
openai-codex/gpt-5.4and its log messages.Actual
Evidence
Attach at least one:
(Optional) Paste the before-fix test failure (AssertionError on
gpt-5.3-codexvsgpt-5.4) and the after-fix “Tests 6 passed” (or equivalent) output.Human Verification (required)
vitest run src/commands/models/auth.test.ts(or fullpnpm testfor models auth); the two updated tests pass; no other tests in that file were changed or broken.Review Conversations
Compatibility / Migration
Failure Recovery (if this breaks)
src/commands/models/auth.test.ts.src/commands/models/auth.test.tsonly.Risks and Mitigations
None. Test expectations were updated to match existing production default; no behavior or defaults were changed.