refactor: migrate outlines to tailwind#1116
Merged
JammingBen merged 1 commit intomainfrom Aug 26, 2025
Merged
Conversation
JammingBen
force-pushed
the
refactor/tailwind-outline
branch
from
32d88ed to
f41fd73
Compare
JammingBen
force-pushed
the
refactor/tailwind-outline
branch
from
f41fd73 to
49e54b6
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates CSS outline declarations from custom SCSS to Tailwind utility classes as part of a broader design system refactor. The changes standardize outline handling across components by removing manual CSS outline rules and replacing them with Tailwind's outline utilities.
- Replaces custom CSS
outline: nonedeclarations with Tailwind'soutline-0class - Converts focus outline styles from SCSS to Tailwind utilities with proper focus states
- Updates component templates and test snapshots to reflect the new Tailwind-based outline classes
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-runtime/src/components/SkipTo.vue | Adds focus:outline-0 class and removes CSS outline: none |
| packages/web-pkg/src/components/ViewOptions.vue | Migrates range input outline from CSS to Tailwind |
| packages/web-pkg/src/components/SideBar/SideBar.vue | Converts sidebar focus outline to Tailwind utilities |
| packages/web-pkg/src/components/FilesList/ResourceTile.vue | Replaces CSS outline with Tailwind classes for tile cards |
| packages/web-pkg/src/components/FilesList/ResourceListItem.vue | Migrates link outline styles to Tailwind |
| packages/web-pkg/src/components/FilesViewWrapper.vue | Converts wrapper focus outline to Tailwind |
| packages/web-app-files/src/components/FilesViewWrapper.vue | Adds focus:outline-0 and outline-0 classes |
| packages/web-app-app-store/src/views/AppDetails.vue | Replaces CSS outline with Tailwind border class |
| packages/web-app-app-store/src/components/AppTile.vue | Converts tile outline from CSS to Tailwind border |
| packages/design-system/src/styles/theme/oc-form.scss | Removes CSS outline declarations for form elements |
| packages/design-system/src/styles/theme/helper.scss | Migrates global focus-visible outline to layers.css |
| packages/design-system/src/styles/layers.css | Adds utilities layer with focus-visible outline styles |
| packages/design-system/src/components/*/**.vue | Updates various design system components to use Tailwind outline utilities |
| /tests//snapshots/*.snap | Updates test snapshots to reflect new Tailwind classes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
AlexAndBear
approved these changes
Aug 26, 2025
openclouders
pushed a commit
that referenced
this pull request
Aug 26, 2025
refactor: migrate outlines to tailwind
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #937