Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes various Tailwind CSS regressions by updating utility classes to maintain visual consistency across components. The changes primarily involve replacing deprecated or incorrect CSS classes with proper Tailwind equivalents.
- Replaces
borderwithoutlinefor better visual rendering - Updates height specifications using bracket notation for precise values
- Adjusts spacing and layout classes for improved component appearance
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-runtime/src/components/Topbar/NotificationBell.vue | Adds box-content class to notification badge |
| packages/web-pkg/src/components/Filters/ItemFilterInline.vue | Replaces border with outline and removes custom SCSS height styles |
| packages/web-pkg/src/components/FilesList/ResourceTiles.vue | Reduces top padding from pt-6 to pt-2 |
| packages/web-pkg/src/components/SideBar/Spaces/Details/SpaceDetails.vue | Adds bottom margin to space image container |
| packages/web-app-ocm/src/views/App.vue | Adds margin to connections panel container |
| packages/web-app-files/src/components/Search/List.vue | Adds max-w-full class to search highlights |
| packages/web-app-app-store/src/components/AppTile.vue | Adds top margin to app actions component |
| packages/design-system/src/components/OcRecipient/OcRecipient.vue | Replaces border with outline and align-center with items-center |
| packages/design-system/src/components/OcFilterChip/OcFilterChip.vue | Adds explicit height and removes conflicting CSS |
| packages/design-system/src/components/OcBreadcrumb/OcBreadcrumb.vue | Adds border radius to dragover state |
| packages/design-system/src/styles/layers.css | Adds break-all to tooltip content |
| index.html | Updates splash screen layout and styling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| <template> | ||
| <span | ||
| class="oc-recipient bg-role-surface-container flex align-center justify-center border border-role-outline rounded-md" | ||
| class="oc-recipient bg-role-surface-container flex items-center justify-center outline outline-role-outline rounded-md" |
There was a problem hiding this comment.
Using outline instead of border may cause accessibility issues as outlines are typically reserved for focus indicators. Consider using border with appropriate offset adjustments if visual consistency is the goal.
Suggested change
| class="oc-recipient bg-role-surface-container flex items-center justify-center outline outline-role-outline rounded-md" | |
| class="oc-recipient bg-role-surface-container flex items-center justify-center border border-role-outline rounded-md" |
AlexAndBear
approved these changes
Aug 27, 2025
openclouders
pushed a commit
that referenced
this pull request
Aug 28, 2025
fix: tailwind regressions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commits for details.
refs #937