Merged
Conversation
JammingBen
force-pushed
the
refactor/tailwind-overflow
branch
from
aa65dff to
a51c9bb
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors overflow CSS classes from custom OpenCloud classes to standard Tailwind CSS classes. The migration simplifies the codebase by removing custom CSS and adopting Tailwind's utility classes for better consistency and maintainability.
Key changes:
- Replaced
oc-overflow-hiddenwithoverflow-hidden - Replaced
oc-overflow-autowithoverflow-autooroverflow-y-auto - Replaced
oc-text-overflowwithmax-w-full,overflow-hidden,truncate, oroverflow-visibledepending on context - Removed corresponding SCSS styles in favor of Tailwind classes
Reviewed Changes
Copilot reviewed 62 out of 62 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-runtime/src/pages/account.vue | Migrated overflow CSS from SCSS to Tailwind class |
| packages/web-runtime/src/layouts/Application.vue | Updated layout overflow classes to Tailwind utilities |
| packages/web-runtime/src/components/UploadInfo.vue | Replaced custom overflow CSS with Tailwind class |
| packages/web-runtime/src/components/Topbar/UserMenu.vue | Updated dropdown overflow class |
| packages/web-runtime/src/components/Topbar/Notifications.vue | Migrated notification dropdown overflow styles |
| packages/web-runtime/src/components/SidebarNav/SidebarNav.vue | Updated sidebar overflow classes |
| packages/web-runtime/src/App.vue | Migrated root app overflow from SCSS to Tailwind |
| packages/web-pkg/src/components/SideBar/SideBar.vue | Updated sidebar panel overflow handling |
| packages/web-pkg/src/components/FilesList/ResourceTile.vue | Fixed resource name wrapper overflow |
| packages/web-pkg/src/components/FilesList/ResourceListItem.vue | Updated text overflow classes for resource items |
| packages/web-pkg/src/components/Filters/DateFilter.vue | Migrated filter overflow styles |
| packages/web-pkg/src/components/Modals/SaveAsModal.vue | Updated modal overflow handling |
| packages/design-system/src/components/OcModal/OcModal.vue | Migrated modal overflow to Tailwind |
| packages/design-system/src/components/OcCheckbox/OcCheckbox.vue | Updated checkbox overflow class |
| packages/design-system/src/components/OcProgress/OcProgress.vue | Migrated progress bar overflow |
| packages/design-system/src/styles/theme/oc-form.scss | Removed custom overflow styles |
| Test snapshots | Updated to reflect new Tailwind class names |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kulmann
approved these changes
Sep 1, 2025
Member
kulmann
left a comment
kulmann
left a comment
There was a problem hiding this comment.
so nice to see, that entire style blocks are now going away 🥳
openclouders
pushed a commit
that referenced
this pull request
Sep 1, 2025
refactor: overflow to tailwind
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #937
Migration
oc-overflow-hidden>overflow-hiddenoc-overflow-auto>overflow-autooc-text-overflow> depends a bit on the situation, usuallymax-w-fulland/oroverflow-hidden