refactor: remaining flex props, display and fill to tailwind#1146
Merged
JammingBen merged 5 commits intomainfrom Sep 4, 2025
Merged
refactor: remaining flex props, display and fill to tailwind#1146JammingBen merged 5 commits intomainfrom
JammingBen merged 5 commits intomainfrom
Conversation
Member
Author
|
Currently waiting for #1138. |
JammingBen
force-pushed
the
refactor/remaining-flex-and-display-to-tailwind
branch
2 times, most recently
from
8a1cf7f to
ba0de9c
Compare
JammingBen
commented
Sep 4, 2025
Comment on lines
-352
to
-356
| .files-app-bar-controls { | ||
| @media (max-width: $oc-breakpoint-xsmall-max) { | ||
| justify-content: space-between; | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
Was already set on the element.
packages/web-app-admin-settings/src/components/Groups/SideBar/EditPanel.vue
Show resolved
Hide resolved
packages/web-app-admin-settings/src/components/Groups/SideBar/GroupInfoBox.vue
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors remaining flex properties and display utilities from custom CSS classes to Tailwind equivalents, migrating oc-display-block to block, oc-display-inline-block to inline-block, and updating dropdown button justify-content handling to be explicitly set per component rather than globally.
Key changes:
- Migrate display utilities to Tailwind classes
- Replace global dropdown button styling with explicit justify-content props
- Remove redundant CSS in favor of Tailwind utilities
Reviewed Changes
Copilot reviewed 75 out of 75 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-runtime/src/pages/resolvePublicLink.vue | Migrate display class and move text-input-message styling to inline Tailwind |
| packages/web-runtime/src/components/Topbar/UserMenu.vue | Add explicit justify-content="left" to buttons and migrate display class |
| packages/web-runtime/src/components/Topbar/TopBar.vue | Move justify-center to responsive classes |
| packages/design-system/src/components/OcButton/OcButton.vue | Move items-center to base button styling |
| Various test snapshots | Update snapshots to reflect new class changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JammingBen
force-pushed
the
refactor/remaining-flex-and-display-to-tailwind
branch
from
ba0de9c to
b088f54
Compare
kulmann
approved these changes
Sep 4, 2025
JammingBen
deleted the
refactor/remaining-flex-and-display-to-tailwind
branch
openclouders
pushed a commit
that referenced
this pull request
Sep 4, 2025
…d-display-to-tailwind refactor: remaining flex props, display and fill to tailwind
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration
oc-display-block>blockoc-display-inline-block>inline-blockAlso, in dropdowns you need to set
justify-contentfor buttons manually now if it differs from the default (center). Previously this was set globally. But then we needed to make exceptions where we don't want this behavior. So it was quite a mess. A bit more verbose now, but clean.refs #937