feat: set tiles view as default view option#1159
Merged
AlexAndBear merged 10 commits intomainfrom Sep 12, 2025
Merged
Conversation
AlexAndBear
force-pushed
the
tiles-default-view
branch
from
e3aaa63 to
21e35ee
Compare
AlexAndBear
commented
Sep 9, 2025
AlexAndBear
commented
Sep 9, 2025
AlexAndBear
force-pushed
the
tiles-default-view
branch
2 times, most recently
from
a887736 to
5605def
Compare
AlexAndBear
commented
Sep 9, 2025
AlexAndBear
force-pushed
the
tiles-default-view
branch
2 times, most recently
from
602324b to
c602220
Compare
Contributor
|
@AlexAndBear I fixed this step but next step is failed it seems that we cannot move file to folder using drag-drop. (moving folder to folder works) |
Contributor
Screen.Recording.2025-09-10.at.12.03.12.mp4 |
Member
Author
It looks like that this issue only applies to files that have a preview, moving e.G PDF files (which doesn't have a preview) do work |
Member
Author
fixed |
AlexAndBear
commented
Sep 10, 2025
| }) | ||
|
|
||
| // Disable lazy loading during E2E tests to avoid having to scroll in tests | ||
| const areTilesLazy = (window as any).__E2E__ === true ? false : lazy |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR sets the tiles view as the default view option for the files interface, replacing the previous table view default. The change implements a UX improvement by making the more visual tiles view the primary interface for browsing files and folders.
- Changes the default view mode from "resource-table" to "resource-tiles"
- Updates E2E test selectors to handle both table and tiles view modes
- Adds functionality to reduce tile size and disable lazy loading during tests
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-pkg/src/composables/viewMode/constants.ts | Changes default view mode from table to tiles |
| packages/web-pkg/src/components/AppBar/AppBar.vue | Updates default prop to use new constant |
| packages/web-app-files/src/views/spaces/Projects.vue | Uses new default constant instead of hardcoded tiles mode |
| packages/web-pkg/src/components/FilesList/ResourceTiles.vue | Adds test attributes and disables lazy loading for E2E tests |
| packages/web-pkg/src/components/FilesList/ResourceTile.vue | Adds test attributes to thumbnail images |
| packages/web-pkg/src/components/FilesList/ResourceTable.vue | Adds test attributes to checkboxes |
| packages/web-pkg/src/components/FilesList/ResourceListItem.vue | Adds test attributes to thumbnails |
| packages/web-pkg/src/components/ContextActions/ContextMenuQuickAction.vue | Adds test attribute for context menu identification |
| tests/e2e/support/objects/app-files/utils/sidebar.ts | Updates selector to work with both view modes |
| tests/e2e/support/objects/app-files/resource/utils.ts | Updates resource name selector for both view modes |
| tests/e2e/support/objects/app-files/resource/actions.ts | Updates selectors and adds tile size reduction functionality |
| tests/e2e/support/environment/actor/actor.ts | Adds E2E test flag to window object |
| Multiple test feature files | Adds explicit table view switching for tests that require it |
| Multiple snapshot files | Updates snapshots to reflect new default view mode |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
|
@AlexAndBear we have only mobile failed test. Here is fix #1173 |
AlexAndBear
force-pushed
the
tiles-default-view
branch
from
fc4036b to
e5226c2
Compare
Merged
# Conflicts: # tests/e2e/cucumber/steps/ui/resources.ts # tests/e2e/support/objects/app-files/resource/actions.ts # tests/e2e/support/objects/app-files/resource/index.ts
AlexAndBear
force-pushed
the
tiles-default-view
branch
from
e5226c2 to
cc11d6e
Compare
…g manually to table view in e2e tests
JammingBen
approved these changes
Sep 12, 2025
openclouders
pushed a commit
that referenced
this pull request
Sep 12, 2025
Co-authored-by: Viktor Scharf <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes