Expand accessibility testing coverage#1164
Merged
ScharfViktor merged 1 commit intomainfrom Sep 11, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR significantly expands accessibility testing coverage by adding comprehensive accessibility checks across different parts of the application, including new test steps and infrastructure. The changes enhance the existing e2e test framework to enable accessibility validation using automated testing tools.
- Adds comprehensive accessibility testing for file views, admin settings, and UI components
- Introduces new test step definitions and page object methods to support a11y testing
- Refactors existing trashbin navigation logic to be more granular and testable
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/cucumber/features/a11y/smoke.feature | Comprehensive accessibility test scenarios covering files, admin settings, and UI components |
| tests/e2e/cucumber/steps/ui/*.ts | New step definitions for accessibility testing workflows |
| tests/e2e/support/objects/*/actions.ts | New methods for opening panels, menus, and navigation |
| tests/e2e/support/objects/*/index.ts | Updated interfaces to expose new accessibility testing functionality |
| tests/e2e/support/api/davSpaces/*.ts | Added file deletion API support for test cleanup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
7c8c604 to
562c729
Compare
ScharfViktor
commented
Sep 10, 2025
JammingBen
reviewed
Sep 11, 2025
57c84f1 to
198d44f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related:
#819
#886
#889
After a full system scan, the test detected:
test output: