Merged
Conversation
ScharfViktor
force-pushed
the
fixMobileTest
branch
from
621f5eb to
2b2b984
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a race condition in mobile end-to-end tests when opening Collabora documents. The test was flaky because it was trying to wait for multiple asynchronous operations simultaneously with the click action, causing timing issues.
- Separates the waiting operations from the click action to ensure proper sequencing
- Waits for load state, URL change, and response only after clicking the Create button
- Fixes the Promise.all pattern around editor.close() to prevent race conditions
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+446
to
448
| const respPromise = Promise.all([ | ||
| page.waitForResponse((res) => res.status() === 207 && res.request().method() === 'PROPFIND') | ||
| ]) |
There was a problem hiding this comment.
Using Promise.all() with a single promise is unnecessary. Consider directly awaiting the waitForResponse call or removing the Promise.all wrapper for clarity.
Suggested change
| const respPromise = Promise.all([ | |
| page.waitForResponse((res) => res.status() === 207 && res.request().method() === 'PROPFIND') | |
| ]) | |
| const respPromise = page.waitForResponse((res) => res.status() === 207 && res.request().method() === 'PROPFIND') |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix race condition when opening Collabora
Wait for load state, URL change, and response only after clicking Create button. Ensures Collabora is available before proceeding.