fix: space edit readme button visible for space members without permissions#1180
Merged
AlexAndBear merged 2 commits intomainfrom Sep 11, 2025
Merged
fix: space edit readme button visible for space members without permissions#1180AlexAndBear merged 2 commits intomainfrom
AlexAndBear merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the space edit readme button was visible to space members who lack the necessary permissions to edit the readme. The fix implements proper permission checking to conditionally show the edit button.
- Adds visibility check for the edit readme button based on user permissions
- Imports and uses the
useSpaceActionsEditReadmeContentcomposable for permission validation - Wraps the edit button container with a conditional directive
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+152
to
+154
| const isEditReadmeVisible = computed(() => | ||
| unref(editReadmeContentActions)[0].isVisible({ resources: [space] }) | ||
| ) |
There was a problem hiding this comment.
Accessing array index [0] without checking if the array has elements could cause a runtime error. Consider adding a safety check or using optional chaining.
Suggested change
| const isEditReadmeVisible = computed(() => | |
| unref(editReadmeContentActions)[0].isVisible({ resources: [space] }) | |
| ) | |
| const isEditReadmeVisible = computed(() => { | |
| const actions = unref(editReadmeContentActions); | |
| return actions.length > 0 ? actions[0].isVisible({ resources: [space] }) : false; | |
| }) |
JammingBen
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes