fix: check byte length on name validation instead of character count#1187
Merged
AlexAndBear merged 3 commits intomainfrom Sep 16, 2025
Merged
fix: check byte length on name validation instead of character count#1187AlexAndBear merged 3 commits intomainfrom
AlexAndBear merged 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes resource name validation from checking character count to checking byte length, addressing issues with multi-byte Unicode characters that could cause validation to pass but fail at the backend level.
- Updates validation logic to use
TextEncoderfor accurate byte length calculation - Increases the maximum allowed bytes from 63 characters to 256 bytes
- Simplifies error messages to be more generic
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/web-pkg/src/constants.ts | Adds new RESOURCE_NAME_MAX_BYTES constant (256) |
| packages/web-pkg/src/composables/actions/helpers/useIsResourceNameValid.ts | Replaces character length validation with byte length validation using TextEncoder |
| packages/web-pkg/tests/unit/composables/actions/helpers/useIsResourceNameValid.spec.ts | Updates test cases to use new byte-based validation and simplified error messages |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/web-pkg/src/composables/actions/helpers/useIsResourceNameValid.ts
Outdated
Show resolved
Hide resolved
packages/web-pkg/src/composables/actions/helpers/useIsResourceNameValid.ts
Outdated
Show resolved
Hide resolved
packages/web-pkg/src/composables/actions/helpers/useIsResourceNameValid.ts
Outdated
Show resolved
Hide resolved
packages/web-pkg/src/composables/actions/helpers/useIsResourceNameValid.ts
Outdated
Show resolved
Hide resolved
2 tasks
AlexAndBear
force-pushed
the
enhance-name-length-validation
branch
from
35b2438 to
57225f1
Compare
github-project-automation
bot
moved this from In Progress
to Done
in OpenCloud Team Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes