Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a flaky test in the sidebar closing functionality by replacing unstable visibility checks with Playwright's built-in expect assertions. The change addresses test flakiness related to timing issues when determining which sidebar button is visible.
- Replaces manual
isVisible()check withexpect().toBeVisible()for more reliable element detection - Uses Playwright's
or()locator to handle either sub-panel or root panel button visibility - Removes arbitrary timeout that was previously used to wait for sidebar transitions
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
I restarted the pipeline several times. It seems the flaky is gone. |
AlexAndBear
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
await page.locator(closeSidebarSubPanelBtn).isVisible()--> is FLAKY don't use it https://playwright.dev/docs/api/class-locator#locator-is-visibleRelated Issue
How Has This Been Tested?
Types of changes