fix: add missing web-pkg types and fix type errors#1266
Merged
JammingBen merged 2 commits intomainfrom Sep 26, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes type errors in the web-pkg package by adding missing type declarations and correcting type inconsistencies. The changes improve TypeScript compilation and ensure proper type safety across the codebase.
- Adds missing type definitions and includes proper source files in TypeScript configuration
- Fixes type parameter mismatches in table component event handlers
- Updates build configuration to generate types with proper directory structure
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-pkg/vite.config.ts | Updates DTS plugin configuration to specify entry root and output directory |
| packages/web-pkg/tsconfig.json | Adds missing type declarations and source files to TypeScript includes |
| packages/web-pkg/src/components/FilesList/ResourceTable.vue | Fixes parameter types for drag-drop handlers and event data processing |
| packages/design-system/src/components/OcTable/OcTable.vue | Corrects component reference types in table row event emissions |
| packages/design-system/src/components/OcAvatars/OcAvatars.vue | Adds missing userId property and slot type definitions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kulmann
approved these changes
Sep 26, 2025
openclouders
pushed a commit
that referenced
this pull request
Sep 26, 2025
fix: add missing web-pkg types and fix type errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes opencloud-eu/web-extensions#220