Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds tiles view support for trash content by enabling folder view modes in the trash interface. The changes allow users to switch between different view modes (table, tiles, etc.) when browsing deleted files in the trash, providing a more flexible viewing experience.
- Introduces a new trash extension point for folder views
- Adds view mode switching capabilities to the trash interface
- Updates existing folder view extensions to support trash contexts
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-pkg/src/components/FilesList/ResourceTiles.vue | Adds areResourcesClickable prop to control clickability of resources in tiles view |
| packages/web-app-files/src/views/spaces/GenericTrash.vue | Replaces hardcoded ResourceTable with dynamic component selection based on view mode |
| packages/web-app-files/src/extensionPoints.ts | Defines new trash extension point for folder views |
| packages/web-app-files/src/composables/extensions/useFolderViews.ts | Updates existing folder view extensions to include trash extension point |
| packages/web-app-files/tests/unit/views/spaces/GenericTrash.spec.ts | Updates test to mock extension registry and folder view extensions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
2 tasks
AlexAndBear
changed the title
AlexAndBear
force-pushed
the
generic-trash-support-tiles-view
branch
from
eeed01a to
177bc02
Compare
# Conflicts: # packages/web-app-files/src/composables/extensions/useFolderViews.ts
AlexAndBear
force-pushed
the
generic-trash-support-tiles-view
branch
from
e280f5b to
486ba4b
Compare
AlexAndBear
force-pushed
the
generic-trash-support-tiles-view
branch
from
a75266c to
8b77af5
Compare
JammingBen
reviewed
Oct 7, 2025
Co-authored-by: Jannik Stehle <[email protected]>
Co-authored-by: Jannik Stehle <[email protected]>
JammingBen
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes