fail accessibility tests on any violation#1319
Merged
ScharfViktor merged 1 commit intomainfrom Oct 7, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the accessibility testing behavior to fail on any accessibility violation rather than only on critical violations. Previously, the test would only fail for critical accessibility issues, but now it will fail immediately when any violation is detected.
- Removed conditional logic that only failed tests on critical accessibility violations
- Simplified error handling to throw an error for any accessibility violation
- Updated OpenCloud commit ID reference
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/e2e/support/utils/accessibility.ts | Simplified accessibility checking to fail on any violation instead of only critical ones |
| .woodpecker.env | Updated OpenCloud commit ID reference |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
Member
Contributor
Author
|
@micbar suggested to delete now locally works fine. waiting CI
|
d059fdf to
d4f21b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Now that we fixed all a11y issues (see #889), I switched the test to fail if new a11y issues appear.