fix (test-e2e): proper use of keycloak admin user#1348
Conversation
saw-jan
force-pushed
the
test/fix-keycloak-test
branch
from
6480c5d to
929e97c
Compare
Signed-off-by: Saw-jan <[email protected]>
saw-jan
force-pushed
the
test/fix-keycloak-test
branch
from
929e97c to
54b83a1
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR separates the concerns of Keycloak admin user management from OpenCloud admin user management in the e2e test framework. It introduces a dedicated function to create Keycloak admin user objects and updates all relevant API calls to use this specific admin user instead of the generic admin user.
- Creates a new
getKeycloakAdminUser()function that returns a properly structured admin user object - Replaces all calls to
getAdminUser()withgetKeycloakAdminUser()in Keycloak API operations - Refactors token management functions to work specifically with the Keycloak admin user
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/support/utils/tokenHelper.ts | Reorders function parameters for better consistency |
| tests/e2e/support/utils/index.ts | Exports the tokenHelper module |
| tests/e2e/support/api/keycloak/utils.ts | Replaces setupKeycloakAdminUser with getKeycloakAdminUser function |
| tests/e2e/support/api/keycloak/user.ts | Updates all Keycloak API calls to use the dedicated admin user |
| tests/e2e/support/api/keycloak/openCloudUserToken.ts | Refactors token management functions for Keycloak admin user |
| tests/e2e/cucumber/environment/index.ts | Updates test setup and teardown to use new admin token functions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Description
Define and use keycloak admin wherever needed, and separate it from opencloud admin.
Related Issue
How Has This Been Tested?
Types of changes