fix: remove share avatar click handler in files table#1349
Merged
JammingBen merged 2 commits intomainfrom Oct 9, 2025
Merged
Conversation
We decided to remove the click handler because it just opened the right sidebar for, which is not really a connected to the share avatars.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the click handler functionality from share avatars in the files table. The click handler previously opened the right sidebar when users clicked on share avatars, but this functionality was deemed unconnected to the actual purpose of the share avatars.
- Removed click handlers from both "sharedBy" and "sharedWith" avatar components
- Deleted the
openSharingSidebarmethod that was handling the click events - Updated test selectors to use data-testid attributes instead of CSS classes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/web-pkg/src/components/FilesList/ResourceTable.vue | Removed oc-button wrappers and openSharingSidebar method from share avatar components |
| packages/web-pkg/tests/unit/components/FilesList/ResourceTable.spec.ts | Updated test selectors to use data-testid instead of CSS class selectors |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
AlexAndBear
approved these changes
Oct 9, 2025
openclouders
pushed a commit
that referenced
this pull request
Oct 9, 2025
…ick-handler fix: remove share avatar click handler in files table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We decided to remove the click handler because it just opened the right sidebar for, which is not really a connected to the share avatars.
fixes #1329