Skip to content

fix: show previews in trash overview#1362

Merged
AlexAndBear merged 3 commits intomainfrom
issues/1356
Oct 13, 2025
Merged

fix: show previews in trash overview#1362
AlexAndBear merged 3 commits intomainfrom
issues/1356

Conversation

@AlexAndBear
Copy link
Member

@AlexAndBear AlexAndBear commented Oct 10, 2025

Description

image ## Related Issue

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

Copilot AI reviewed Oct 10, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables preview functionality for files in the trash overview by integrating preview loading capabilities. The change ensures that users can view file previews when items become visible in the trash folder view.

  • Added preview loading functionality to the trash overview
  • Integrated space matching and preview loading composables

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

JammingBen
JammingBen reviewed Oct 13, 2025
View reviewed changes
Copy link
Member

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, but the browser console is logging TypeError: resource.hasPreview is not a function when accessing the trash overview for me 🤔

@AlexAndBear
Copy link
Member Author

AlexAndBear commented Oct 13, 2025

Works fine, but the browser console is logging TypeError: resource.hasPreview is not a function when accessing the trash overview for me 🤔

Good catch, this is originated from the personal space. Since the interface for space images is quite different, I adjusted the check

@AlexAndBear AlexAndBear merged commit 8569e9e into main Oct 13, 2025
28 checks passed
@AlexAndBear AlexAndBear deleted the issues/1356 branch October 13, 2025 09:16
@openclouders openclouders mentioned this pull request Oct 13, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@JammingBen JammingBen JammingBen approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees

No one assigned

Labels

Type:Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Trash overview has no space images

3 participants

@AlexAndBear @JammingBen