Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fix sidebar affecting tile size by reacting to sidebar open state and preventing invalid CSS variable updates.
- Add a guard to avoid setting the tile size CSS variable when the value is invalid.
- Trigger tile width recalculation when the sidebar opens/closes.
- Add a FIXME in useSideBar noting the need for a global store to avoid duplicate listeners.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/web-pkg/src/composables/sideBar/useSideBar.ts | Adds a FIXME comment referencing migrating to a global store to prevent multiple event listeners. |
| packages/web-pkg/src/components/FilesList/ResourceTiles.vue | Imports useSideBar, watches sidebar open state to recalc view width, and guards setting the CSS variable only when tile size is valid. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JammingBen
force-pushed
the
fix/sidebar-tilesize-change
branch
from
d2504db to
a576a43
Compare
JammingBen
force-pushed
the
fix/sidebar-tilesize-change
branch
from
a576a43 to
194ef7c
Compare
AlexAndBear
approved these changes
Oct 20, 2025
openclouders
pushed a commit
that referenced
this pull request
Oct 21, 2025
fix: sidebar messing with tile size
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1359