Merged
Conversation
JammingBen
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors Vue components to use the Composition API (<script setup>) syntax instead of the Options API, while fixing a bug where password enforcement was incorrectly determined based on the current link type rather than the target link type when changing roles.
Key Changes:
- Replaced
isPasswordEnforcedprop with dynamicisPasswordEnforcedForLinkType()check using the target type - Converted
ListItem.vueandFileLinks.vuefrom Options API to Composition API syntax - Removed unused
isPasswordEnforcedprop fromListItemcomponent
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/web-app-files/src/components/SideBar/Shares/Links/ListItem.vue |
Converted to Composition API and replaced static isPasswordEnforced prop with dynamic isPasswordEnforcedForLinkType(type) check |
packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue |
Converted to Composition API and removed isPasswordEnforced prop binding |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Adds a password modal that prompts the user for a password when changing the role from viewer to editor and the editor role is configured to require a password.
JammingBen
force-pushed
the
fix/password-link-enforcement
branch
from
91f7638 to
feb3f60
Compare
AlexAndBear
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a password modal that prompts the user for a password when changing the role from viewer to editor and the editor role is configured to require a password.
To review the actual change: b6112e2
fixes #1379