Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the display of plain views (such as public/private link resolution and access-denied pages) on mobile devices by adding responsive padding and width classes to ensure proper rendering across different screen sizes.
Key changes:
- Added responsive padding (
p-4) to page containers for better mobile spacing - Updated card width classes from fixed widths to responsive widths using Tailwind breakpoints
- Migrated multiple Vue components from Options API to Composition API (
<script setup>)
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/web-runtime/src/pages/resolvePublicLink.vue | Migrated to script setup and added responsive layout classes |
| packages/web-runtime/src/pages/resolvePrivateLink.vue | Migrated to script setup and added responsive layout classes |
| packages/web-runtime/src/pages/accessDenied.vue | Migrated to script setup and added responsive layout classes |
| packages/web-runtime/src/pages/logout.vue | Migrated to script setup and added responsive layout classes |
| packages/web-runtime/src/pages/login.vue | Migrated to script setup |
| packages/web-runtime/src/pages/oidcCallback.vue | Migrated to script setup |
| packages/web-runtime/src/pages/notFound.vue | Added responsive padding and text centering |
| packages/web-runtime/src/pages/missingOrInvalidConfig.vue | Added responsive padding and header text centering |
| packages/web-runtime/tests/unit/pages/resolvePublicLink.spec.ts | Updated tests to use flushPromises instead of task.last |
| packages/web-runtime/tests/unit/pages/resolvePrivateLink.spec.ts | Updated tests to use flushPromises instead of task.last |
| packages/web-runtime/tests/unit/pages/snapshots/accessDenied.spec.ts.snap | Updated snapshot to reflect responsive layout changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JammingBen
force-pushed
the
fix/messy-mobile-views
branch
from
b7467b2 to
daef8f2
Compare
JammingBen
force-pushed
the
fix/messy-mobile-views
branch
from
daef8f2 to
d1e41a7
Compare
AlexAndBear
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the mobile display of plain views such as the public/private link resolving or the access-denied page.
fixes #1371