fix: add wait for upload input before setInputFiles#1428
Merged
ScharfViktor merged 1 commit intomainfrom Oct 24, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses timing issues in end-to-end tests related to file and folder uploads, particularly for webkit mobile environments. The changes ensure that upload input elements are properly attached to the DOM before attempting to interact with them.
Key Changes:
- Added explicit wait for upload input element attachment before calling
setInputFiles() - Enabled CSP bypass for mobile webkit browser context to resolve upload-related issues
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/e2e/support/objects/app-files/resource/actions.ts | Adds waitFor call to ensure upload input is attached before file upload |
| tests/e2e/support/environment/actor/shared.ts | Enables bypassCSP for mobile webkit device configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ScharfViktor
force-pushed
the
fix/upload-input-timeout
branch
2 times, most recently
from
a441383 to
3e09190
Compare
Contributor
Author
|
I restarted CI a couple of times. https://ci.opencloud.eu/repos/6/pipeline/97/191 seems it works |
ScharfViktor
force-pushed
the
fix/upload-input-timeout
branch
from
6a254df to
bf0cc09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed two problems:
#files-folder-upload-inputbefore starting upload datasometimes we got error: